1747555 - smoosh/build.rs: use `if let` instead of a match

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1747544 +++

Filling as a good first bug to learn workflows.

if let will suffice.

TEST-UNEXPECTED-WARNING | /builds/worker/checkouts/gecko/js/src/frontend/smoosh/build.rs:18:5 | you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` (clippy::single_match) 

https://searchfox.org/mozilla-central/rev/cc4a22e024a23183e53696bf6dc5014e407a29ff/js/src/frontend/smoosh/build.rs#18-23

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by https://rust-lang.github.io/rust-clippy/master/#single_match

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[Gustavo Silva]

Attachment: Bug 1747555 - smoosh/build.rs - Replaces match with if let. r=sylvestre

Comment 2

[Gustavo Silva]

Hello!

I followed the process and I pushed the submission to Phabricator - Hope I did it right and assigned you as the reviewer of the change. I'm sorry if I did not but I am not used to Mercurial and all these tools :)

Please let me know your feedback and what I missed, if anything.

Thanks in advance!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14a29694003a
smoosh/build.rs - Replaces match with if let. r=arai

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/14a29694003a