1747772 - Allow to build using clang's integrated assembler

Status: RESOLVED FIXED

(NSS :: Build, task)

Description

[Mike Hommey [:glandium]]

This is related to bug 1724353, but I'm not going to go with a full fix for reasons that will be enunciated in the phabricator summary.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1747772 - Allow to build using clang's integrated assembler.

Since clang 9, NSS can build for x86_64 without the -fno-integrated-as
flag.

The tricky part is that clang versions are unreliable. For instance, a
check for "clang version 9 or more" would break building with Xcode
versions between 9.0 and 11.3.1 (because clang in those say it has
version >= 9, but they are actually clang versions between 4.0 and 8.0;
the clang version reflects the Xcode version, not the real clang version).

We do have a complicated version check in Firefox that works around
that, but I don't feel like porting this to NSS, so instead, allow
to set a gyp variable to force enable it, and let the Firefox build
system decide for itself.

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/projects/nss/rev/d982efc0e22d3739246786de419e6051f7a5e4a2

Benjamin, when can we get this in m-c?

Comment 3

[Benjamin Beurdouche [:beurdouche]]

As discussed, this will be uplifted to m-c as part of NSS 3.75, right after merge day.