1747805 - NETWORK_EVENT resources are always flagged with the top level target front/innerWindowId

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Alexandre Poirot [:ochameau] [PTO back Jan 5th]]

All NETWORK_EVENT resources for iframe requests are flagged with the wrong innerWindowId because of the following typo:
https://searchfox.org/mozilla-central/rev/e74a8e2d1dedebfe47a6afb009ddabdeea12694b/devtools/server/actors/network-monitor/utils/network-utils.js#110

    return channel.loadInfo.innerWindowId;

Because nsILoadInfo exposes the id with this wording:
https://searchfox.org/mozilla-central/source/netwerk/base/nsILoadInfo.idl#759

 [infallible] readonly attribute unsigned long long innerWindowID;

Because of that the targetFront attribute of each iframe's NETWORK_EVENT was always the top level target front.
I'm not sure it translate into any user visible bug, but we weren't clearing requests of iframe when the iframe is removed:
https://searchfox.org/mozilla-central/rev/e74a8e2d1dedebfe47a6afb009ddabdeea12694b/devtools/server/actors/resources/network-events.js#177

        if (child.innerWindowId == innerWindowId) {

So fixing this we will start destroying the NetworkEventActor when iframes are removed, this can translate into blank sidebars in netmonitor when persist is OFF.
We may tune the NetworkEventActor cleanup code if we consider that's wrong.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back Jan 5th]]

Attachment: Bug 1747805 - [devtools] Fix NETWORK_EVENT's innerWindowID and clear requests of iframe when they get destroyed.

This also fixes the targetFront attribute for NETWORK_EVENT resources of iframes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ea2e2e52761
[devtools] Fix NETWORK_EVENT's innerWindowID and clear requests of iframe when they get destroyed. r=nchevobbe

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4ea2e2e52761