1747804 - HAR file export still results in an empty file

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Alexandre Poirot [:ochameau]]

Bug 1740116's comment 0 still reproduces, but may now require two subsequent reload of the test page to reproduce consistantly.

I did not realized but bug 1740116's patch only fixed one issue specific to cancelled request.
It looks like we also fail generating HAR reports because of iframes being removed.
When removing an iframe, we destroy the related iframe's NetworkEventActors and so can't fetch the related requests lazy data.

We should probably make HAR codebase more resilient to error and start with ignoring individual requests that we are unable to fetch. So that we at least generate the HAR report for everything else.

We may also consider automatically enabling persist when doing HAR record? Or display some warning when retrieving HAR data while persist is disabled.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1747804 - [devtools] Fix har export when some requests can't be retrieved.

HAR export was still producing empty har files if any of the request
currently displayed in the netmonitor can't be completely retrieved.
This includes all lazy data. But if any request has been destroyed in the server
fetching any lazy data will throw.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b10ddd0ec17
[devtools] Fix har export when some requests can't be retrieved. r=nchevobbe

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0b10ddd0ec17