Closed Bug 1747952 Opened 2 years ago Closed 2 years ago

Missing network printers on Fedora 35

Categories

(Core :: Printing: Setup, defect, P2)

Unspecified
Linux
defect

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox-esr91 --- wontfix
firefox95 --- wontfix
firefox96 --- wontfix
firefox97 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

I'm sure I can't be the only person to be experiencing this, but my network printer is missing from Firefox on Fedora 35. This seems to be down to us filtering out CUPS_PRINTER_DISCOVERED printers. We started doing that in bug 1667978 to avoid long pauses waiting for the printer list to be generated. Instead of doing that we should probably include them and set a sensible timeout time. For my printer (connected to wifi), a timeout of 25 ms is enough for CUPS to add it to the list of enumerated print destinations. We should probably also make this value configurable via a pref to allow easier debugging and control for anyone else experiencing missing printers.

The timeout is configurable via the pref print.cups_enum_dests_timeout_ms.

See Also: → 1658414
See Also: → 1666937

Set release status flags based on info from the regressing bug 1667978

Attachment #9257120 - Attachment description: Bug 1747952 - Include discovered/network printers in the CUPS list on Linux, with a timeout. r=emilio → Bug 1747952 - Include discovered/network printers in the CUPS list, with a timeout. r=emilio
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/df442e234a16
Include discovered/network printers in the CUPS list, with a timeout. r=emilio

Interesting. I guess we had a pre-existing leak here but never hit the error case in CI to expose it.

Flags: needinfo?(jwatt)
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/d69272c85ef1
Include discovered/network printers in the CUPS list, with a timeout. r=emilio

Backed out for causing mochitest failures(leak at cupsArrayNew3)

Flags: needinfo?(jwatt)

Gah. The failure moved from c1 to c3, so my Try push missed this is still failing.

https://treeherder.mozilla.org/jobs?repo=try&revision=ade0261d9d07eda761da9a74c9b8996a3e97e0b0

Flags: needinfo?(jwatt)

Seems this is a leak in the cups library. I've filed an upstream pull request at https://github.com/OpenPrinting/cups/pull/317

And for the record, any of the following tests in https://searchfox.org/mozilla-central/source/layout/base/tests/chrome/ will trigger this in Linux ASAN builds on CI (it doesn't repro locally on Fedora 35):

  • test_printer_default_settings.html
  • test_get_printer_basic_attributes.html
  • test_get_printer_paper_sizes.html
  • test_get_printer_orientation.html
Component: Printing: Output → Printing: Setup
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/fcbcac27e338
Include discovered/network printers in the CUPS list, with a timeout. r=emilio,decoder
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
QA Whiteboard: [qa-97b-p2]
Flags: needinfo?(vlad.lucaci)
Has Regression Range: --- → yes

Hello,

I have attempted to reproduce this issue with the STR provided in description and did not succeed.

STR were performed on KDE Neon, Fedora 35 as well as Ubuntu 20 using the affected build 97.0a1(20211229214859) as well as the latest Nightly 101.0a1(20220414092955) .

Jwatt , If you have access to this OS and configuration, please let us know if this issue still occurs.
Thank you.

Flags: needinfo?(vlad.lucaci)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: