1748159 - Improve keyboard support for search box in about:logins

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P2)

Description

[Sergey Galich [:serg]]

While in search box user must be able to:

1. Press up or down keys to select previous or next item in the list.

2. Use ENTER to display selected item.

3. Use ESC to clear search text.

Comment 1

[Sergey Galich [:serg]]

Attachment: Bug 1748159 - +3 to Keyboard in about:logins. r=dimi,tgiles

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afa7965bd643
+3 to Keyboard in about:logins. r=dimi

Comment 3

[Sam Foster [:sfoster] (he/him)]

Can we give this bug a better title? I've read comment #0 and the patch we landed and I still don't understand what "+3" means in this context.

Comment 4

[Sergey Galich [:serg]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #3)

Can we give this bug a better title? I've read comment #0 and the patch we landed and I still don't understand what "+3" means in this context.

sure

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/afa7965bd643

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 97.0a1 (Build ID: 20220104034109) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

• The searched logins can be focused using the “up” and “down” arrow keys and they can be accessed by pressing the “Enter” key.
• The searched text from the search box is cleared after pressing the “Esc” key.