Closed Bug 1745020 Opened 3 years ago Closed 3 years ago

Fix overflow issue on about:logins

Categories

(Firefox :: about:logins, defect, P3)

defect

Tracking

()

VERIFIED FIXED
97 Branch
Tracking Status
firefox96 --- verified
firefox97 --- verified

People

(Reporter: serg, Assigned: tgiles)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

Attachments

(1 obsolete file)

  • mouse scroll can move whole page content up and down revealing unused bottom area
  • keyboard navigation state is not cleared after mouse selection
  • ENTER/SPACE while selecting item with keyboard loses focus
  • tab order jumps all over the place
  • up/down keys in search box does not select previous/next item in list
  • create login button placement is inside invisible corner
  • search box aligned over details view, but affects list view
  • login count must say "23 of 146 logins" not just "23 logins" when filtered
Assignee: nobody → sgalich
Severity: -- → N/A
Priority: -- → P3
Attachment #9254356 - Attachment description: Bug 1745020 - Fix overflow issue on about:logins. r=sgalich!,prathiksha → Bug 1745020 - Fix overflow issue on about:logins. r=sgalich!,cmkm
Pushed by sgalich@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c905815eb29 Fix overflow issue on about:logins. r=sgalich,cmkm
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 1746036
Keywords: leave-open
Status: REOPENED → ASSIGNED
Target Milestone: 97 Branch → ---

Comment on attachment 9254356 [details]
Bug 1745020 - Fix overflow issue on about:logins. r=sgalich!,cmkm

Revision D133227 was moved to bug 1746189. Setting attachment 9254356 [details] to obsolete.

Attachment #9254356 - Attachment is obsolete: true
Depends on: 1748159
Blocks: 1748500

I created bug 1748500 to be the meta bug instead.

Severity: N/A → --
Status: ASSIGNED → RESOLVED
Type: task → defect
Closed: 3 years ago3 years ago
No longer depends on: 1746036, 1748159
Keywords: leave-open, meta
Resolution: --- → FIXED
Summary: [meta] things to review on about:logins UI → Fix overflow issue on about:logins
Target Milestone: --- → 97 Branch

Hi Mathew, is there anything that QA can verify on this issue?

Flags: needinfo?(mathew.hodson)

(In reply to Simona Rosu [:srosu], Ecosystem QA from comment #7)

Hi Mathew, is there anything that QA can verify on this issue?

Same steps as in bug 1746189.

Flags: needinfo?(mathew.hodson)

Based on comment 4 and comment 9 from Bug 1746189, I’m marking this issue as Verified Fixed.

Status: RESOLVED → VERIFIED
Assignee: sgalich → tgiles
Regressions: 1757151
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: