1748509 - Add builder fields to snapshot groups and more indices

Status: RESOLVED FIXED

(Toolkit :: Places, task, P2)

Description

[Mark Banner (:standard8)]

We want to add more fields for snapshot groups and at the same time add a couple more indices to help improve grouping performance.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1748509 - Add builder fields to snapshot groups and more indices. r?mak!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5130029a12c6
Add builder fields to snapshot groups and more indices. r=mak

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 5130029a12c6 (Bug 1748509) for causing failures in browser_startup_mainthreadio.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=N9mM2JDaS4al9zhJ6DgCMg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5130029a12c653985905083f57b743baa28b95b7

Log: https://treeherder.mozilla.org/logviewer?job_id=363137936&repo=autoland&lineNumber=2519
Also: https://treeherder.mozilla.org/logviewer?job_id=363137265&repo=autoland&lineNumber=85053
https://treeherder.mozilla.org/logviewer?job_id=363144129&repo=autoland&lineNumber=4826

Backout: https://hg.mozilla.org/integration/autoland/rev/bb48e67ce459a9e2e28c6ca12e5096985922f732

Comment 4

[Mark Banner (:standard8)]

Forgot about the mainthreadio changes, I have fixed those now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7c3bb99e390
Add builder fields to snapshot groups and more indices. r=mak

Comment 6

[Marian-Vasile Laza]

Backed out changeset b7c3bb99e390 (Bug 1748509) for causing high freq bc failures on browser_startup_mainthreadio.js.
Backout link
Push with failures
Failure Log

Comment 7

[Mark Banner (:standard8)]

I didn't expect that to be intermittent and try didn't pick up the failure :(

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/480b5274349b
Add builder fields to snapshot groups and more indices. r=mak

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/480b5274349b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing profile corruption as noted in the Matrix chat below:

Latest nightly update lost all browsing history
related to sqlite upgrade?
places db seems to be empty nowq
have a places.sqlite.corrupt file in the profile folder which has a size that makes sense
favicons.sqlite.corrupt
looks like the sqlite broke everything

Aryx was able to reproduce as well.

https://hg.mozilla.org/mozilla-central/rev/b442a7921285ec569a5676f2aa02e4097ddef6b5

Given that we're in the middle of the Nightly soft freeze, please wait to re-land this until after the 98 version bump lands on Monday.

Comment 11

[Jim Jeffery not reading bug-mail 1/2/11]

Anyway to recover the corruption ?

Comment 12

[Mark Banner (:standard8)]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #11)

Anyway to recover the corruption ?

Firefox should have remembered your bookmarks, but will not have remembered your history.

If you want to get the history back, it looks like you can updated to the latest nightly (which should have the patch backed out), shut it down and then go into your profile, replace places.sqlite/favicons.sqlite with the places.sqlite.corrupt and favicons.sqlite.corrupt versions.

Comment 13

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Mark Banner (:standard8) from comment #12)

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #11)

Anyway to recover the corruption ?

Firefox should have remembered your bookmarks, but will not have remembered your history.

If you want to get the history back, it looks like you can updated to the latest nightly (which should have the patch backed out), shut it down and then go into your profile, replace places.sqlite/favicons.sqlite with the places.sqlite.corrupt and favicons.sqlite.corrupt versions.

Thanks Mark, that worked..

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f500edac6e7b
Add builder fields to snapshot groups and more indices. r=mak

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f500edac6e7b