1748558 - menu namespace persistent listeners

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Shane Caraveo (:mixedpuppy)]

Modifications to support non-persistent background scripts (event pages and/or service workers)

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1748558 persistence for menus events

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1748558 enforce requirement of id in menus apis for event pages

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1748558 menu startupCache persistence

Add a StartupCache for menus created during runtime.onInstalled

Comment 6

[Phabricator Automation]

Comment on attachment 9269912 [details]
Bug 1748558 menu startupCache persistence

Revision D139789 was moved to bug 1762394. Setting attachment 9269912 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d254a677ce9e
persistence for menus events r=robwu
https://hg.mozilla.org/integration/autoland/rev/4dbc1e13c9ce
enforce requirement of id in menus apis for event pages r=robwu

Comment 8

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_ext_contextMenus_commands.js

Backout link

Push with failures

Failure log

Failure line(s): TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_contextMenus_commands.js | exactly one menu item found - Got +0, expected 1

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75beaa94e216
persistence for menus events r=robwu,rpl
https://hg.mozilla.org/integration/autoland/rev/cbe1a85e93de
enforce requirement of id in menus apis for event pages r=robwu

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/75beaa94e216
https://hg.mozilla.org/mozilla-central/rev/cbe1a85e93de