1748594 - [win] Clicking two times on Save to Pocket button inside Reader Mode sometimes opens a different dimension Pocket window

Status: NEW

(Firefox :: Theme, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

Attachment: pocket_00.gif

Affected versions

• 97.0a1 (20220104214425)
• 96.0 (20220103221059)
• 95.0.2 (20211218203254)
• 91.4.1esr (20211215182543)

Affected platforms

• Windows 10x64

Steps to reproduce

1. Open Firefox with a new profile and https://en.wikipedia.org/wiki/Main_Page.
2. Enter reader mode.
3. Click the Save to Pocket button two times.

Expected result

• Save to Pocket closes.

Actual result

• Save to pocket dropdown is opened again with a different window size.

Regression range

• Last good revision: b7fcd3a7571f8a88918d767b2a429e63a5e076c7
  First bad revision: 6308384f47a72f3f9b86e1158fd26ba9dc856c98
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b7fcd3a7571f8a88918d767b2a429e63a5e076c7&tochange=6308384f47a72f3f9b86e1158fd26ba9dc856c98

Notes

• Screen recording attached.
• Note that the issue is intermittent.
• On macOS 10.15 and Ubuntu 20.04 it seems that the pocket window size does not change.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1694285

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hi Alexandru,

The regression range you identified - are you certain? I looked at the change and I can't see how it could have introduced this - the style changes in introduces are for other panel types (permission panels, for example) and should not have affected the Pocket panel at all.

When you reproduce the issue, do you happen to see any errors in the browser console?

Comment 3

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #2)

Hi Alexandru,

The regression range you identified - are you certain? I looked at the change and I can't see how it could have introduced this - the style changes in introduces are for other panel types (permission panels, for example) and should not have affected the Pocket panel at all.

Hello Mike and sorry for the late response,

I ran mozregression again here and I got the same pushlog unfortunately. I think that what happens here is this:

• on good builds when clicking the Save to Pocket button a second time the pocket menu closes
• on bad builds when clicking the second time the pocket menu reopens again and is not closing like on "good" builds and maybe this causes the dimension change. Note that the issue is intermittent.

When you reproduce the issue, do you happen to see any errors in the browser console?

I don't see nothing in beta when I reproduce. I see lots of these in Nightly when multi-clicking the Pocket button inside Reader Mode:
debuggee 'resource://devtools/shared/loader/base-loader.js:289' would run : builtin-modules.js:206:11 (resource://devtools/shared/loader/builtin-modules.js)