1748730 - Ensure overlay is removed whenever the screenshot UI is closed/cancelled

Status: RESOLVED FIXED

(Firefox :: Screenshots, enhancement, P3)

Description

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

In the browser component implementation, the overlay is managed in the content process, while the main logic and UI are in the browser's parent/main process. So we need to be careful to ensure that whenever Screenshots is cancelled or that UI closed, the overlay is removed.

We should add tests for navigation in the tab being screenshot, as well as validating what we expect to happen when the active tab changes at each phase in the screenshot flow.

Comment 1

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

This implementation has landed, but I think we should add test coverage for the cases in comment #0 to close this bug.

Comment 2

[Niklas Baumgardner [:niklas]]

We need to add some logic to keep the overlay and panel in sync when switching tabs. The panel is handled by the parent and the overlay is handled by the child so they can get out of sync currently.

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1748730 - The screenshots overlay and panel are now always in sync. r=sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/878107275a58
The screenshots overlay and panel are now always in sync. r=sfoster

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/878107275a58