Closed Bug 1749044 (AudioDecoder) Opened 2 years ago Closed 2 months ago

[WebCodecs] Implement AudioDecoder

Tracking

()

Status:

RESOLVED FIXED

Milestone:

125 Branch

Tracking Flags:

Tracking

Status

firefox125

---

fixed

People

(Reporter: chunmin, Assigned: padenot)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(15 files, 2 obsolete files)

Bug 1749044 - Allow stealing the memory of an AlignedAudioBuffer. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Fix lingering references to video decoding in DecoderTemplate.cpp. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Instantiate another DecoderTemplate for audio. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Fix typo in VideoDecoder.webidl. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Implement AudioDecoder.cpp. r?chunmin,#webidl 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Move GetExtraData from VideoDecoder.cpp to WebCodecsUtils.cpp. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Improve some error messages. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Remove some unnecessary headers. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Add a const to VideoDecoder code. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Move ADTS parsing facilities to their own file, split from the ADTS demuxer. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Add a function to strip the ADTS header from a packet. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Make AppleATDecoder capable of decoding ATDS bytestream directly r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Fix warnings in WMF code. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Teach the WMF audio decoder to handle ADTS. r?chunmin 6 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Add AudioData, EncodedAudioChunk, AudioDecoder to test_{worker,}_interfaces.html. 2 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - hazard fix 2 months ago C.M.Chang[:chunmin] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1749044 - Fix `error: control reaches end of non-void function` 2 months ago C.M.Chang[:chunmin] 48 bytes, text/x-phabricator-request		Details \| Review

C.M.Chang[:chunmin]

Reporter

Description

•

2 years ago

•

Edited

Implement https://w3c.github.io/webcodecs/#audiodecoder-interface

C.M.Chang[:chunmin]

Reporter

Updated

•

10 months ago

Depends on: 1840965

C.M.Chang[:chunmin]

Reporter

Updated

•

10 months ago

Alias: AudioDecoder

C.M.Chang[:chunmin]

Reporter

Updated

•

10 months ago

Depends on: 1840966

C.M.Chang[:chunmin]

Reporter

Updated

•

10 months ago

Component: Audio/Video → Audio/Video: Web Codecs

Paul Adenot (:padenot)

Assignee

Updated

•

7 months ago

Depends on: 1856626

Paul Adenot (:padenot)

Assignee

Updated

•

6 months ago

Depends on: 1858958

Paul Adenot (:padenot)

Assignee

Updated

•

6 months ago

Depends on: 1859536

Paul Adenot (:padenot)

Assignee

Comment 1

•

6 months ago

Attached file Bug 1749044 - Allow stealing the memory of an AlignedAudioBuffer. r?chunmin (obsolete) — Details

Depends on D192339

Paul Adenot (:padenot)

Assignee

Comment 2

•

6 months ago

Attached file Bug 1749044 - Fix lingering references to video decoding in DecoderTemplate.cpp. r?chunmin — Details

Depends on D192340

Paul Adenot (:padenot)

Assignee

Comment 3

•

6 months ago

Attached file Bug 1749044 - Instantiate another DecoderTemplate for audio. r?chunmin — Details

Depends on D192341

Paul Adenot (:padenot)

Assignee

Comment 4

•

6 months ago

Attached file Bug 1749044 - Fix typo in VideoDecoder.webidl. r?chunmin — Details

Depends on D192342

Paul Adenot (:padenot)

Assignee

Comment 5

•

6 months ago

Attached file Bug 1749044 - Implement AudioDecoder.cpp. r?chunmin,#webidl — Details

Depends on D192350

Paul Adenot (:padenot)

Assignee

Comment 6

•

6 months ago

Attached file Bug 1749044 - Move GetExtraData from VideoDecoder.cpp to WebCodecsUtils.cpp. r?chunmin — Details

Depends on D192351

Paul Adenot (:padenot)

Assignee

Comment 7

•

6 months ago

Attached file Bug 1749044 - Improve some error messages. r?chunmin — Details

Depends on D191663

Paul Adenot (:padenot)

Assignee

Comment 8

•

6 months ago

Attached file Bug 1749044 - Remove some unnecessary headers. r?chunmin — Details

Depends on D192355

Paul Adenot (:padenot)

Assignee

Comment 9

•

6 months ago

Attached file Bug 1749044 - Add a const to VideoDecoder code. r?chunmin (obsolete) — Details

Depends on D192356

Paul Adenot (:padenot)

Assignee

Comment 10

•

6 months ago

Attached file Bug 1749044 - Move ADTS parsing facilities to their own file, split from the ADTS demuxer. r?chunmin — Details

Depends on D192357

Paul Adenot (:padenot)

Assignee

Comment 11

•

6 months ago

Attached file Bug 1749044 - Add a function to strip the ADTS header from a packet. r?chunmin — Details

Depends on D192360

Paul Adenot (:padenot)

Assignee

Comment 12

•

6 months ago

Attached file Bug 1749044 - Make AppleATDecoder capable of decoding ATDS bytestream directly r?chunmin — Details

Depends on D192361

Paul Adenot (:padenot)

Assignee

Comment 13

•

6 months ago

Attached file Bug 1749044 - Fix warnings in WMF code. r?chunmin — Details

Depends on D192363

Paul Adenot (:padenot)

Assignee

Comment 14

•

6 months ago

Attached file Bug 1749044 - Teach the WMF audio decoder to handle ADTS. r?chunmin — Details

Depends on D192684

Phabricator Automation

Updated

•

3 months ago

Attachment #9361217 - Attachment is obsolete: true

Phabricator Automation

Updated

•

3 months ago

Attachment #9361240 - Attachment is obsolete: true

Pulsebot

Comment 15

•

2 months ago

Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd71b745d729
Fix lingering references to video decoding in DecoderTemplate.cpp. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/7badb720d24b
Instantiate another DecoderTemplate for audio. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/961feba09c71
Fix typo in VideoDecoder.webidl. r=chunmin,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/dec9ce7a61a0
Implement AudioDecoder.cpp. r=chunmin,webidl,saschanaz,smaug
https://hg.mozilla.org/integration/autoland/rev/e8a916a76c18
Move GetExtraData from VideoDecoder.cpp to WebCodecsUtils.cpp. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/145a8190f6fc
Improve some error messages. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/583617a9e949
Remove some unnecessary headers. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a33714bc62c4
Move ADTS parsing facilities to their own file, split from the ADTS demuxer. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/2ec9140f8724
Add a function to strip the ADTS header from a packet. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/7a3cd601c7a1
Make AppleATDecoder capable of decoding ATDS bytestream directly r=chunmin
https://hg.mozilla.org/integration/autoland/rev/6e7ee116c90e
Fix warnings in WMF code. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/20d58a991964
Teach the WMF audio decoder to handle ADTS. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/21402b00cc81
1858958, 1859536: apply code formatting via Lando

Pulsebot

Comment 16

•

2 months ago

Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cc1feaa4278
Fix lingering references to video decoding in DecoderTemplate.cpp. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/51a9560dca83
Instantiate another DecoderTemplate for audio. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/2766ff1803eb
Fix typo in VideoDecoder.webidl. r=chunmin,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/604de77ebdb0
Implement AudioDecoder.cpp. r=chunmin,webidl,saschanaz,smaug
https://hg.mozilla.org/integration/autoland/rev/82415829c98e
Move GetExtraData from VideoDecoder.cpp to WebCodecsUtils.cpp. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/6236dad2f515
Improve some error messages. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/4a4df823adf4
Remove some unnecessary headers. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/b8ef52c64b38
Move ADTS parsing facilities to their own file, split from the ADTS demuxer. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/9fc353b8689f
Add a function to strip the ADTS header from a packet. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/3c961124ae96
Make AppleATDecoder capable of decoding ATDS bytestream directly r=chunmin
https://hg.mozilla.org/integration/autoland/rev/cfeaef572769
Fix warnings in WMF code. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/1a7064c0b046
Teach the WMF audio decoder to handle ADTS. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/ef3fdc0aff0b
1858958, 1859536: apply code formatting via Lando

Iulian Moraru

Comment 17

•

2 months ago

•

Edited

Backed out for causing multiple build bustages on GleanMetricsBinding.cpp.

Push with failures
Failure log
This also caused some mochitest-plain failures:
Failure log for failures on test_worker_interfaces.html
Failure log for failures on test_interfaces.html
Backout link

[task 2024-03-06T11:28:55.546Z] 11:28:55     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/bindings'
[task 2024-03-06T11:28:55.553Z] 11:28:55     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --target=x86_64-linux-android21 -o UnifiedBindings8.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -D_FORTIFY_SOURCE=0 -fno-common -DNDEBUG=1 -DTRIMMED=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/bindings -I/builds/worker/workspace/obj-build/dom/bindings -I/builds/worker/workspace/obj-build/dist/include/mozilla/dom -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/dom/battery -I/builds/worker/checkouts/gecko/dom/canvas -I/builds/worker/checkouts/gecko/dom/geolocation -I/builds/worker/checkouts/gecko/dom/html -I/builds/worker/checkouts/gecko/dom/indexedDB -I/builds/worker/checkouts/gecko/dom/media/webaudio -I/builds/worker/checkouts/gecko/dom/media/webrtc -I/builds/worker/checkouts/gecko/dom/media/webrtc/common/time_profiling -I/builds/worker/checkouts/gecko/dom/media/webrtc/jsapi -I/builds/worker/checkouts/gecko/dom/media/webrtc/libwebrtcglue -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport -I/builds/worker/checkouts/gecko/dom/media/webspeech/recognition -I/builds/worker/checkouts/gecko/dom/svg -I/builds/worker/checkouts/gecko/dom/xml -I/builds/worker/checkouts/gecko/dom/xslt/base -I/builds/worker/checkouts/gecko/dom/xslt/xpath -I/builds/worker/checkouts/gecko/dom/xul -I/builds/worker/checkouts/gecko/js/xpconnect/src -I/builds/worker/checkouts/gecko/js/xpconnect/wrappers -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/style -I/builds/worker/checkouts/gecko/layout/xul/tree -I/builds/worker/checkouts/gecko/media/webrtc -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/third_party/libwebrtc -I/builds/worker/checkouts/gecko/third_party/libwebrtc/third_party/abseil-cpp -I/builds/worker/checkouts/gecko/third_party/msgpack/include -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h --sysroot=/builds/worker/fetches/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot --gcc-toolchain=/builds/worker/fetches/android-ndk/toolchains/llvm/prebuilt/linux-x86_64 -fno-sized-deallocation -fno-aligned-new -fsanitize=address -fno-short-enums -fcrash-diagnostics-dir=/builds/worker/artifacts -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -gdwarf-4 -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/UnifiedBindings8.o.pp   UnifiedBindings8.cpp
[task 2024-03-06T11:28:55.554Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.554Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:645:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.554Z] 11:28:55     INFO -    645 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.554Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.554Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.555Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.559Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:1076:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -   1076 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.560Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:1542:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -   1542 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.560Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:1975:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -   1975 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.560Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:2406:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -   2406 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.561Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:2938:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -   2938 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.561Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:3373:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -   3373 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.562Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:3593:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -   3593 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.562Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:3906:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -   3906 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.562Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:4336:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -   4336 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.563Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:4814:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -   4814 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.563Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:5245:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -   5245 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.564Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.564Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.564Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.564Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:5775:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.565Z] 11:28:55     INFO -   5775 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.565Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.565Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.566Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.566Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.566Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.566Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:6206:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.574Z] 11:28:55     INFO -   6206 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.574Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.574Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.574Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.575Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.575Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.575Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:6738:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.576Z] 11:28:55     INFO -   6738 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.576Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.576Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.577Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.577Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.577Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.578Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:7287:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.578Z] 11:28:55     INFO -   7287 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.578Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.579Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.579Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.579Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.579Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.580Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:7718:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.580Z] 11:28:55     INFO -   7718 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.580Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.581Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.581Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.581Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.582Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.582Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:8183:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.582Z] 11:28:55     INFO -   8183 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.582Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.583Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.583Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.583Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.584Z] 11:28:55     INFO -  18 errors generated.
[task 2024-03-06T11:28:55.584Z] 11:28:55    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:688: UnifiedBindings8.o] Error 1
[task 2024-03-06T11:28:55.584Z] 11:28:55     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/bindings'

Flags: needinfo?(cchang)

Pulsebot

Comment 18

•

2 months ago

Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb2e210c3246
Fix lingering references to video decoding in DecoderTemplate.cpp. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/484ec6aa065a
Instantiate another DecoderTemplate for audio. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/1bc0265853cd
Fix typo in VideoDecoder.webidl. r=chunmin,webidl,saschanaz
https://hg.mozilla.org/integration/autoland/rev/6d0921a963ab
Implement AudioDecoder.cpp. r=chunmin,webidl,saschanaz,smaug
https://hg.mozilla.org/integration/autoland/rev/ffa4324d0fb9
Move GetExtraData from VideoDecoder.cpp to WebCodecsUtils.cpp. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/1b896e0ad784
Improve some error messages. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/3707f59635a6
Remove some unnecessary headers. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/ff08fc853950
Move ADTS parsing facilities to their own file, split from the ADTS demuxer. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/6ce519ea48a7
Add a function to strip the ADTS header from a packet. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/283d31c4a53d
Make AppleATDecoder capable of decoding ATDS bytestream directly r=chunmin
https://hg.mozilla.org/integration/autoland/rev/4d5b911550d5
Fix warnings in WMF code. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/f019ed5f865c
Teach the WMF audio decoder to handle ADTS. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/ba378029cc4a
1858958, 1859536: apply code formatting via Lando

Paul Adenot (:padenot)

Assignee

Comment 19

•

2 months ago

Attached file Bug 1749044 - Add AudioData, EncodedAudioChunk, AudioDecoder to test_{worker,}_interfaces.html. — Details

Phabricator Automation

Updated

•

2 months ago

Attachment #9389695 - Attachment description: Bug 1749044 - Mirror AudioData, EncodedAudioChunk, AudioDecoder to test_worker_interfaces.html. → WIP: Bug 1749044 - Add AudioData, EncodedAudioChunk, AudioDecoder to test_{worker,}_interfaces.html.

Phabricator Automation

Updated

•

2 months ago

Attachment #9389695 - Attachment description: WIP: Bug 1749044 - Add AudioData, EncodedAudioChunk, AudioDecoder to test_{worker,}_interfaces.html. → Bug 1749044 - Add AudioData, EncodedAudioChunk, AudioDecoder to test_{worker,}_interfaces.html.

Pulsebot

Comment 20

•

2 months ago

Pushed by imoraru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/899703a93bcf
Add AudioData, EncodedAudioChunk, AudioDecoder to test_{worker,}_interfaces.html. r=fix CLOSED TREE

C.M.Chang[:chunmin]

Reporter

Comment 21

•

2 months ago

Attached file Bug 1749044 - hazard fix — Details

C.M.Chang[:chunmin]

Reporter

Comment 22

•

2 months ago

Attached file Bug 1749044 - Fix `error: control reaches end of non-void function` — Details

Depends on D203866

Phabricator Automation

Updated

•

2 months ago

Attachment #9389858 - Attachment description: WIP: Bug 1749044 - hazard fix → Bug 1749044 - hazard fix

Phabricator Automation

Updated

•

2 months ago

Attachment #9389859 - Attachment description: WIP: Bug 1749044 - Fix `error: control reaches end of non-void function` → Bug 1749044 - Fix `error: control reaches end of non-void function`

Pulsebot

Comment 23

•

2 months ago

Pushed by smolnar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bddb10d2d55
hazard fix r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/9915fb51518c
Fix `error: control reaches end of non-void function` r=media-playback-reviewers,alwu

C.M.Chang[:chunmin]

Reporter

Updated

•

2 months ago

Assignee: cchang → padenot

Flags: needinfo?(cchang)

Narcis Beleuzu [:NarcisB]

Comment 24

•

2 months ago

bugherder

Status: NEW → RESOLVED

Closed: 2 months ago

status-firefox125: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 125 Branch

You need to log in before you can comment on or make changes to this bug.