Closed Bug 1858958 Opened 11 months ago Closed 7 months ago

Implement AudioData

Tracking

()

Status:

RESOLVED FIXED

Milestone:

125 Branch

Tracking Flags:

Tracking

Status

firefox125

---

fixed

People

(Reporter: padenot, Assigned: padenot)

References

Details

Attachments

(10 files, 1 obsolete file)

Bug 1858958 - WebIDL file and skeleton code for AudioData. r?chunmin,#webidl 11 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1858958 - AudioData lifetime: constructors, close, clone. r?chunmin 11 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1858958 - Rewrite audio sample type conversion code. r?chunmin 11 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1858958 - Fix callers of audio sample type conversion facilities. r?chunmin 11 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1858958 - AudioData: copyTo. r?chunmin 11 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1858958 - AudioData: structured cloning. r?chunmin 11 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1858958 - AudioData: all WPT now pass. r?chunmin 11 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1858958 - Rewrite lots of the AudioData.copyTo test to support all sample-types. r?chunmin 11 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1858958 - Test more conversions, clearly mark planar->interleaved conversion as outside of spec. r?chunmin 11 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1858958 - Rewrite lots of the AudioData.copyTo test to support all sample-types. r?chunmin 11 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1858958 - Mark AudioData tests that are optional to implement as such. r?chunmin 11 months ago Paul Adenot (:padenot) 48 bytes, text/x-phabricator-request		Details \| Review

Paul Adenot (:padenot)

Assignee

Description

•

11 months ago

https://w3c.github.io/webcodecs/#audiodata

Paul Adenot (:padenot)

Assignee

Comment 1

•

11 months ago

Attached file Bug 1858958 - WebIDL file and skeleton code for AudioData. r?chunmin,#webidl — Details

Paul Adenot (:padenot)

Assignee

Comment 2

•

11 months ago

Attached file Bug 1858958 - AudioData lifetime: constructors, close, clone. r?chunmin — Details

Depends on D190943

Paul Adenot (:padenot)

Assignee

Comment 3

•

11 months ago

Attached file Bug 1858958 - Rewrite audio sample type conversion code. r?chunmin — Details

Depends on D190944

Paul Adenot (:padenot)

Assignee

Comment 4

•

11 months ago

Attached file Bug 1858958 - Fix callers of audio sample type conversion facilities. r?chunmin — Details

Depends on D190945

Paul Adenot (:padenot)

Assignee

Comment 5

•

11 months ago

Attached file Bug 1858958 - AudioData: copyTo. r?chunmin — Details

Depends on D190946

Paul Adenot (:padenot)

Assignee

Comment 6

•

11 months ago

Attached file Bug 1858958 - AudioData: structured cloning. r?chunmin — Details

Depends on D190947

Paul Adenot (:padenot)

Assignee

Comment 7

•

11 months ago

Attached file Bug 1858958 - AudioData: all WPT now pass. r?chunmin — Details

Depends on D190948

BugBot [:suhaib / :marco/ :calixte]

Comment 8

•

11 months ago

The severity field is not set for this bug.
:padenot, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(padenot)

Phabricator Automation

Updated

•

11 months ago

Attachment #9358342 - Attachment description: WIP: Bug 1858958 - WebIDL file and skeleton code for AudioData. r?chunmin,#webidl-reviewers → Bug 1858958 - WebIDL file and skeleton code for AudioData. r?chunmin,#webidl

Phabricator Automation

Updated

•

11 months ago

Attachment #9358343 - Attachment description: WIP: Bug 1858958 - AudioData lifetime: constructors, close, clone. r?chunmin → Bug 1858958 - AudioData lifetime: constructors, close, clone. r?chunmin

Phabricator Automation

Updated

•

11 months ago

Attachment #9358344 - Attachment description: WIP: Bug 1858958 - Rewrite audio sample type conversion code. r?chunmin → Bug 1858958 - Rewrite audio sample type conversion code. r?chunmin

Phabricator Automation

Updated

•

11 months ago

Attachment #9358345 - Attachment description: WIP: Bug 1858958 - Fix callers of audio sample type conversion facilities. r?chunmin → Bug 1858958 - Fix callers of audio sample type conversion facilities. r?chunmin

Phabricator Automation

Updated

•

11 months ago

Attachment #9358346 - Attachment description: WIP: Bug 1858958 - AudioData: copyTo. r?chunmin → Bug 1858958 - AudioData: copyTo. r?chunmin

Phabricator Automation

Updated

•

11 months ago

Attachment #9358347 - Attachment description: WIP: Bug 1858958 - AudioData: structured cloning. r?chunmin → Bug 1858958 - AudioData: structured cloning. r?chunmin

Phabricator Automation

Updated

•

11 months ago

Attachment #9358348 - Attachment description: WIP: Bug 1858958 - AudioData: all WPT now pass. r?chunmin → Bug 1858958 - AudioData: all WPT now pass. r?chunmin

Paul Adenot (:padenot)

Assignee

Comment 9

•

11 months ago

Attached file Bug 1858958 - Rewrite lots of the AudioData.copyTo test to support all sample-types. r?chunmin (obsolete) — Details

Depends on D190949

Paul Adenot (:padenot)

Assignee

Comment 10

•

11 months ago

Attached file Bug 1858958 - Test more conversions, clearly mark planar->interleaved conversion as outside of spec. r?chunmin — Details

Depends on D192338

Paul Adenot (:padenot)

Assignee

Comment 11

•

11 months ago

Attached file Bug 1858958 - Rewrite lots of the AudioData.copyTo test to support all sample-types. r?chunmin — Details

Depends on D190949

Phabricator Automation

Updated

•

11 months ago

Attachment #9361212 - Attachment is obsolete: true

Paul Adenot (:padenot)

Assignee

Comment 12

•

11 months ago

Attached file Bug 1858958 - Mark AudioData tests that are optional to implement as such. r?chunmin — Details

Depends on D192352

Sylvestre Ledru [:Sylvestre]

Updated

•

11 months ago

Type: defect → task

Paul Adenot (:padenot)

Assignee

Updated

•

10 months ago

Severity: -- → S2

Flags: needinfo?(padenot)

Priority: -- → P1

Andreas Pehrson [:pehrsons]

Comment 13

•

10 months ago

Since this bug is for implementing a new interface whose absence does not render any form of functional regression, I'm undoing the S2.

Severity: S2 → N/A

Pulsebot

Comment 14

•

7 months ago

Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/745df1a31541 WebIDL file and skeleton code for AudioData. r=chunmin,webidl,saschanaz https://hg.mozilla.org/integration/autoland/rev/25477e671dc0 AudioData lifetime: constructors, close, clone. r=chunmin https://hg.mozilla.org/integration/autoland/rev/73fffa240ac4 Rewrite audio sample type conversion code. r=pehrsons https://hg.mozilla.org/integration/autoland/rev/5fec5cbf2af7 Fix callers of audio sample type conversion facilities. r=chunmin https://hg.mozilla.org/integration/autoland/rev/fdc20c3b80d6 AudioData: copyTo. r=chunmin https://hg.mozilla.org/integration/autoland/rev/ea637545c497 AudioData: structured cloning. r=chunmin,smaug https://hg.mozilla.org/integration/autoland/rev/886b419887c8 AudioData: all WPT now pass. r=chunmin https://hg.mozilla.org/integration/autoland/rev/ac3bb1773f97 Rewrite lots of the AudioData.copyTo test to support all sample-types. r=chunmin https://hg.mozilla.org/integration/autoland/rev/874f792bb36f Test more conversions, clearly mark planar->interleaved conversion as outside of spec. r=chunmin https://hg.mozilla.org/integration/autoland/rev/e67de77033d2 Mark AudioData tests that are optional to implement as such. r=chunmin

Norisz Fay [:noriszfay]

Comment 15

•

7 months ago

Backed out for causing bustages on AppleATDecoder.cpp and AudioData related failures

Backout link

Push with failures

Failure log // Failure log 2

This was backed out together with Bug 1749044 and Bug 1859536

Flags: needinfo?(padenot)

Pulsebot

Comment 16

•

7 months ago

Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b76bd797f69d WebIDL file and skeleton code for AudioData. r=chunmin,webidl,saschanaz https://hg.mozilla.org/integration/autoland/rev/5e6e4e89d29f AudioData lifetime: constructors, close, clone. r=chunmin https://hg.mozilla.org/integration/autoland/rev/c5b578de93bc Rewrite audio sample type conversion code. r=pehrsons https://hg.mozilla.org/integration/autoland/rev/eb8c734baad4 Fix callers of audio sample type conversion facilities. r=chunmin https://hg.mozilla.org/integration/autoland/rev/8f0d8d45d132 AudioData: copyTo. r=chunmin https://hg.mozilla.org/integration/autoland/rev/94c203600f2c AudioData: structured cloning. r=chunmin,smaug https://hg.mozilla.org/integration/autoland/rev/9aa8c8ed1ff7 AudioData: all WPT now pass. r=chunmin https://hg.mozilla.org/integration/autoland/rev/27b465fe92a3 Rewrite lots of the AudioData.copyTo test to support all sample-types. r=chunmin https://hg.mozilla.org/integration/autoland/rev/c41a5aac3192 Test more conversions, clearly mark planar->interleaved conversion as outside of spec. r=chunmin https://hg.mozilla.org/integration/autoland/rev/fb81fa706f77 Mark AudioData tests that are optional to implement as such. r=chunmin

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Comment 17

•

7 months ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44950 for changes under testing/web-platform/tests

Iulian Moraru

Comment 18

•

7 months ago

•

Edited

Backed out for causing multiple build bustages on GleanMetricsBinding.cpp.

Push with failures
Failure log
This also caused some mochitest-plain failures:
Failure log for failures on test_worker_interfaces.html
Failure log for failures on test_interfaces.html
Backout link

[task 2024-03-06T11:28:55.546Z] 11:28:55     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/bindings'
[task 2024-03-06T11:28:55.553Z] 11:28:55     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --target=x86_64-linux-android21 -o UnifiedBindings8.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -D_FORTIFY_SOURCE=0 -fno-common -DNDEBUG=1 -DTRIMMED=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/bindings -I/builds/worker/workspace/obj-build/dom/bindings -I/builds/worker/workspace/obj-build/dist/include/mozilla/dom -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/dom/battery -I/builds/worker/checkouts/gecko/dom/canvas -I/builds/worker/checkouts/gecko/dom/geolocation -I/builds/worker/checkouts/gecko/dom/html -I/builds/worker/checkouts/gecko/dom/indexedDB -I/builds/worker/checkouts/gecko/dom/media/webaudio -I/builds/worker/checkouts/gecko/dom/media/webrtc -I/builds/worker/checkouts/gecko/dom/media/webrtc/common/time_profiling -I/builds/worker/checkouts/gecko/dom/media/webrtc/jsapi -I/builds/worker/checkouts/gecko/dom/media/webrtc/libwebrtcglue -I/builds/worker/checkouts/gecko/dom/media/webrtc/transport -I/builds/worker/checkouts/gecko/dom/media/webspeech/recognition -I/builds/worker/checkouts/gecko/dom/svg -I/builds/worker/checkouts/gecko/dom/xml -I/builds/worker/checkouts/gecko/dom/xslt/base -I/builds/worker/checkouts/gecko/dom/xslt/xpath -I/builds/worker/checkouts/gecko/dom/xul -I/builds/worker/checkouts/gecko/js/xpconnect/src -I/builds/worker/checkouts/gecko/js/xpconnect/wrappers -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/style -I/builds/worker/checkouts/gecko/layout/xul/tree -I/builds/worker/checkouts/gecko/media/webrtc -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/third_party/libwebrtc -I/builds/worker/checkouts/gecko/third_party/libwebrtc/third_party/abseil-cpp -I/builds/worker/checkouts/gecko/third_party/msgpack/include -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h --sysroot=/builds/worker/fetches/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot --gcc-toolchain=/builds/worker/fetches/android-ndk/toolchains/llvm/prebuilt/linux-x86_64 -fno-sized-deallocation -fno-aligned-new -fsanitize=address -fno-short-enums -fcrash-diagnostics-dir=/builds/worker/artifacts -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -gdwarf-4 -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/UnifiedBindings8.o.pp   UnifiedBindings8.cpp
[task 2024-03-06T11:28:55.554Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.554Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:645:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.554Z] 11:28:55     INFO -    645 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.554Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.554Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.555Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.559Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:1076:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -   1076 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.559Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.560Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:1542:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -   1542 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.560Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:1975:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -   1975 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.560Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:2406:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.560Z] 11:28:55     INFO -   2406 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.561Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:2938:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -   2938 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.561Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:3373:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -   3373 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.561Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.562Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:3593:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -   3593 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.562Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:3906:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -   3906 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.562Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:4336:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -   4336 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.562Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.563Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:4814:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -   4814 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.563Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:5245:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -   5245 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.563Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.564Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.564Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.564Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.564Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:5775:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.565Z] 11:28:55     INFO -   5775 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.565Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.565Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.566Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.566Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.566Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.566Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:6206:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.574Z] 11:28:55     INFO -   6206 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.574Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.574Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.574Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.575Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.575Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.575Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:6738:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.576Z] 11:28:55     INFO -   6738 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.576Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.576Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.577Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.577Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.577Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.578Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:7287:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.578Z] 11:28:55     INFO -   7287 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.578Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.579Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.579Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.579Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.579Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.580Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:7718:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.580Z] 11:28:55     INFO -   7718 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.580Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.581Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.581Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.581Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.582Z] 11:28:55     INFO -  In file included from UnifiedBindings8.cpp:2:
[task 2024-03-06T11:28:55.582Z] 11:28:55    ERROR -  ./GleanMetricsBinding.cpp:8183:10: error: incomplete type 'nsGlobalWindowInner' named in nested name specifier
[task 2024-03-06T11:28:55.582Z] 11:28:55     INFO -   8183 |   return nsGlobalWindowInner::IsGleanNeeded(aCx, aObj);
[task 2024-03-06T11:28:55.582Z] 11:28:55     INFO -        |          ^~~~~~~~~~~~~~~~~~~~~
[task 2024-03-06T11:28:55.583Z] 11:28:55     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/OriginTrials.h:15:7: note: forward declaration of 'nsGlobalWindowInner'
[task 2024-03-06T11:28:55.583Z] 11:28:55     INFO -     15 | class nsGlobalWindowInner;
[task 2024-03-06T11:28:55.583Z] 11:28:55     INFO -        |       ^
[task 2024-03-06T11:28:55.584Z] 11:28:55     INFO -  18 errors generated.
[task 2024-03-06T11:28:55.584Z] 11:28:55    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:688: UnifiedBindings8.o] Error 1
[task 2024-03-06T11:28:55.584Z] 11:28:55     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/bindings'

Flags: needinfo?(padenot)

Iulian Moraru

Updated

•

7 months ago

Flags: needinfo?(padenot)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Comment 19

•

7 months ago

Upstream PR was closed without merging

Paul Adenot (:padenot)

Assignee

Updated

•

7 months ago

Flags: needinfo?(padenot)

Pulsebot

Comment 20

•

7 months ago

Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1e56699898a2 WebIDL file and skeleton code for AudioData. r=chunmin,webidl,saschanaz https://hg.mozilla.org/integration/autoland/rev/11e002bf3766 AudioData lifetime: constructors, close, clone. r=chunmin https://hg.mozilla.org/integration/autoland/rev/3f0f010a817f Rewrite audio sample type conversion code. r=pehrsons https://hg.mozilla.org/integration/autoland/rev/0f91085165dd Fix callers of audio sample type conversion facilities. r=chunmin https://hg.mozilla.org/integration/autoland/rev/fdc3b5b9ac9e AudioData: copyTo. r=chunmin https://hg.mozilla.org/integration/autoland/rev/9d5a2c2147a1 AudioData: structured cloning. r=chunmin,smaug https://hg.mozilla.org/integration/autoland/rev/ce0e04c1a62a AudioData: all WPT now pass. r=chunmin https://hg.mozilla.org/integration/autoland/rev/70902f637578 Rewrite lots of the AudioData.copyTo test to support all sample-types. r=chunmin https://hg.mozilla.org/integration/autoland/rev/f86f5e52c4bb Test more conversions, clearly mark planar->interleaved conversion as outside of spec. r=chunmin https://hg.mozilla.org/integration/autoland/rev/1cc93a6b0d63 Mark AudioData tests that are optional to implement as such. r=chunmin

Pulsebot

Comment 21

•

7 months ago

Pushed by imoraru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f4654d81e91 fix build bustages. r=fix CLOSED TREE

Narcis Beleuzu [:NarcisB]

Comment 22

•

7 months ago

bugherder

Status: NEW → RESOLVED

Closed: 7 months ago

status-firefox125: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 125 Branch

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Comment 23

•

7 months ago

Upstream PR merged by moz-wptsync-bot

Petr Sumbera

Updated

•

7 months ago

Regressions: 1884119

Norisz Fay [:noriszfay]

Updated

•

7 months ago

Regressions: 1884211

Treeherder Bug Filer

Updated

•

7 months ago

Regressions: 1884277

Donal Meehan [:dmeehan]

Updated

•

3 months ago

Regressions: 1902555

Takanori MATSUURA

Updated

•

2 months ago

Regressions: 1907438

Takanori MATSUURA

Updated

•

2 months ago

Regressions: 1908231

You need to log in before you can comment on or make changes to this bug.