1749048 - (ImageDecoder) Implement ImageDecoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, enhancement, P1)

Description

[C.M.Chang[:chunmin]]

Implement https://w3c.github.io/webcodecs/#imagedecoder-interface

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

I'm happy to put this together.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Update, 2/3 of tests passing, patches coming soon.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1749048 - Part 1. Expose methods to throw/reject based on a MediaResult.

This patch adds convenience methods to throw on ErrorResult and
reject on Promise directly from a MediaResult which has an nsresult
and a message.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1749048 - Part 2. Implement WebCodecs image decoding API.

This leverages the promise based image decoding API added in bug
1901078 to remap that onto the WebCodecs specification.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b609b8fcff3
Part 1. Expose methods to throw/reject based on a MediaResult. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/0c7ce075a24f
Part 2. Implement WebCodecs image decoding API. r=webidl,media-playback-reviewers,smaug,padenot

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing interface related mochitests failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces_secureContext.html | undefined: If this is failing: DANGER, are you sure you want to expose the new interface ImageDecoder to all webpages as a property of self? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)

Also, please check these mochitests too.

• Failure Log

L.E. There is also a build bustage: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&fromchange=794c0df6ca1546963aeb1eaca946129024d0f0e6&searchStr=linux%2Cx64%2Cdebug%2Chazard-linux64-haz%2Fdebug%2Ch&tochange=dab0dced4b988ff917539070a0a943f97eca274f&selectedTaskRun=Rnmr0kR_TfiwDwdTOl9YLA.0

• Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6aa4e953e922
Part 1. Expose methods to throw/reject based on a MediaResult. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/40ba80bacf94
Part 2. Implement WebCodecs image decoding API. r=webidl,media-playback-reviewers,smaug,padenot

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1901078, Bug 1749048) for causing bustages in ImageDecoder.cpp

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Cdebug%2Chazard-linux64-haz%2Fdebug%2Ch&revision=cbe411e8ee43bc08773dcaead3ca9b64c3843189&selectedTaskRun=ZsrmJATMRPWba3Gi7W0OOw.0
Please check previous comment with the Later Edit

Log: https://treeherder.mozilla.org/logviewer?job_id=467642705&repo=autoland&lineNumber=108613

Backout: https://hg.mozilla.org/integration/autoland/rev/9aaf78863f45f028304432737b4e28c63794e109

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

The easiest way to work around this for now is to just switch to ProcessFixedData. It incurs an extra copy but we already do it in other gfx contexts. I can do a follow up later to improve this.

Comment 10

[Andrew Osmond [:aosmond] (he/him)]

try: https://treeherder.mozilla.org/jobs?repo=try&revision=9ba32efb99eef2fc9d9f694294f4503b7883ed91

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38ee84f0cb41
Part 1. Expose methods to throw/reject based on a MediaResult. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/ad42f737c988
Part 2. Implement WebCodecs image decoding API. r=webidl,media-playback-reviewers,smaug,padenot

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/38ee84f0cb41
https://hg.mozilla.org/mozilla-central/rev/ad42f737c988