1749161 - Does LockRequestChild need to call AbortFollower::Traverse

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Tom S [:evilpie]]

I am looking into implementing my own AbortFollower and I noticed that LockRequestChild doesn't seem to call AbortFollower::Traverse or AbortFollower::Unlink. I am wondering if it should do that.

Comment 1

[Andrew McCreight [:mccr8]]

Thanks for filing. At worst, this will just cause a leak, so it doesn't need to be a security issue.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

LockRequestChild is refcounted but that's only for weakptr support. By design the lifetime of a LockRequest actor is the lifetime of its lock, and that lifetime is controlled by Lock and LockManagerParent. Since they will actively cut the cycle, I think there can't be a leak here.

But Olli, could you also double check?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Yeah, the comment above explains the situation here.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

Thanks, closing.

Thank you Tom for noticing this, though!

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I wonder if some comment somewhere would be useful.

Comment 6

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

I can do that as a part of bug 1660555, since those traverse things are added as parts of that.