Closed Bug 1749403 Opened 3 years ago Closed 3 years ago

Permanent comm-central TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_cookies_thirdparty.js, test_cookies_thirdparty_session.js | Test timed out

Categories

(Thunderbird :: Upstream Synchronization, defect, P5)

Tracking

(thunderbird_esr91 unaffected)

RESOLVED FIXED
98 Branch
Tracking Status
thunderbird_esr91 --- unaffected

People

(Reporter: intermittent-bug-filer, Assigned: mkmelin)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell disable-recommended])

Attachments

(2 files)

Bug 1744091 started this. Not sure what the problem is yet, it could be a different configuration on our end.

Regressed by: 1744091

Yep ./mach xpcshell-test --setpref=fission.autostart=false netwerk/test/unit/test_cookies_thirdparty.js works

But with fission enabled ifr.contentDocument is null - https://searchfox.org/mozilla-central/rev/83e67336083df9f9a3d1e0c33f2ba19703d57161/netwerk/test/unit/head_cookies.js#184

:gbrown, any ideas?

Flags: needinfo?(gbrown)

On mozilla-central, all xpcshell tests still run with fission disabled: taskcluster adds --setpref=fission.autostart=false. For example,
https://treeherder.mozilla.org/logviewer?job_id=363839132&repo=mozilla-central&lineNumber=56

[task 2022-01-12T11:31:21.800Z] executing ['/builds/worker/bin/test-linux.sh', '--xpcshell-suite=xpcshell', '--setpref=media.peerconnection.mtransport_process=false', '--setpref=network.process.enabled=false', '--setpref=layers.d3d11.enable-blacklist=false', '--setpref=fission.autostart=false', '--download-symbols=ondemand']

I don't see that happening in the comm-central link,
https://treeherder.mozilla.org/logviewer?job_id=363630737&repo=comm-central&lineNumber=5335

My patch added that --setpref as part of the 'fission' transform, https://searchfox.org/mozilla-central/source/taskcluster/gecko_taskgraph/transforms/test/fission.py

Flags: needinfo?(gbrown)

Thanks! Much appreciated!

Rob, where do we want to add this configuration for Thunderbird?

Flags: needinfo?(rob)

It looks like the fission transform is working as expected. Am I missing something?

https://treeherder.mozilla.org/logviewer?job_id=363630737&repo=comm-central&lineNumber=57

[task 2022-01-10T20:12:40.980Z] executing ['/builds/worker/bin/test-linux.sh', '--xpcshell-suite=xpcshell', '--setpref=media.peerconnection.mtransport_process=false', '--setpref=network.process.enabled=false', '--setpref=layers.d3d11.enable-blacklist=false', '--setpref=fission.autostart=false', '--download-symbols=ondemand']
Flags: needinfo?(rob)

Hmm, then it's a mystery of why it doesn't take effect. Running with --setpref=fission.autostart=false locally works.

(In reply to Rob Lemley [:rjl] from comment #8)

It looks like the fission transform is working as expected. Am I missing something?

https://treeherder.mozilla.org/logviewer?job_id=363630737&repo=comm-central&lineNumber=57

[task 2022-01-10T20:12:40.980Z] executing ['/builds/worker/bin/test-linux.sh', '--xpcshell-suite=xpcshell', '--setpref=media.peerconnection.mtransport_process=false', '--setpref=network.process.enabled=false', '--setpref=layers.d3d11.enable-blacklist=false', '--setpref=fission.autostart=false', '--download-symbols=ondemand']

That looks exactly right to me. I don't understand why the test still fails.

You could check that the --setpref makes it into the xpcshell harness extraPrefs, and then into the profile.

https://searchfox.org/mozilla-central/rev/080e18fa4748456003164f58b0d925b8c3826a67/testing/xpcshell/runxpcshelltests.py#1166

It seems that running the test locally on Firefox, Services.appinfo.fissionAutostart is false regardless of the pref value, and on Thunderbird it follows the pref. I don't know where the false value comes from, surely it has to be here somewhere but not in the last block where the pref value is used. I haven't got a full Firefox build handy to check.

Ok, so there is apparently a couple of bugs here.

  • Why it doesn't work for Thunderbird: just another problem from bug 1168178 - firefox ends up using the browser.tabs.remote.autostart false from all.js (not firefox.js where it's true) and thunderbird runs with a real profile, picking up browser.tabs.remote.autostart true from all-thunderbird.js
  • Why the --setpref=fission.autostart=false passed by CI doesn't make it to the test (this is true both for Thunderbird and Firefox)

See this try: https://treeherder.mozilla.org/jobs?repo=try&revision=21ef7a4a8f7eefa65ebe6635036398ef7157639f&selectedTaskRun=EWuI4yp_S6iWDLovivHVeA.0 (has some xxxmagnus debug output as well)

Thunderbird tests run with fission enabled, and this test doesn't work with it enabled.
Flags to disable fission are ignored.

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/integration/autoland/rev/ab31b5c40ee5 disable test_cookies_thirdparty.js for Thunderbird. r=necko-reviewers,valentin DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch

There are two failing tests, and only one of them got disabled.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/integration/autoland/rev/0512f711796a disable test_cookies_thirdparty_session.js for Thunderbird. r=valentin,necko-reviewers DONTBUILD
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED

Filed bug 1752502 for second part of comment 19.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: