1749549 - Use a panel for the "hamburger" in the contacts sidebar

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, task)

Description

[Richard Marti (:Paenglab)]

The "hamburger" in the composer's contacts sidebar uses a normal menupopup. For some consistency with the extraAddressRowsMenuButton we could use it in panel style too.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1749549-sidebarAbContextMenu-panel.patch

Try: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=95b3abf856f6b8b86074cef046f01407e1862705

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2022-01-11 11.56.11.png

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9258503 [details] [diff] [review]
1749549-sidebarAbContextMenu-panel.patch

Review of attachment 9258503 [details] [diff] [review]:
-----------------------------------------------------------------

This works great on macOS but on Linux the elements are not properly aligned, and a checkbox is visible underneath the checked icon (see attachment).

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1749549-sidebarAbContextMenu-panel.patch

This should fix the issues.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9258561 [details] [diff] [review]
1749549-sidebarAbContextMenu-panel.patch

Review of attachment 9258561 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e23883d2ce5b
Use the panel for the sidebarAbContextMenu. r=aleca