Closed Bug 1749549 Opened 4 months ago Closed 4 months ago

Use a panel for the "hamburger" in the contacts sidebar

Categories

(Thunderbird :: Message Compose Window, task)

Tracking

(thunderbird_esr91 unaffected)

RESOLVED FIXED
98 Branch
Tracking Status
thunderbird_esr91 --- unaffected

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

The "hamburger" in the composer's contacts sidebar uses a normal menupopup. For some consistency with the extraAddressRowsMenuButton we could use it in panel style too.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9258503 - Flags: review?(alessandro)
Comment on attachment 9258503 [details] [diff] [review]
1749549-sidebarAbContextMenu-panel.patch

Review of attachment 9258503 [details] [diff] [review]:
-----------------------------------------------------------------

This works great on macOS but on Linux the elements are not properly aligned, and a checkbox is visible underneath the checked icon (see attachment).
Attachment #9258503 - Flags: review?(alessandro) → feedback+

This should fix the issues.

Attachment #9258503 - Attachment is obsolete: true
Attachment #9258561 - Flags: review?(alessandro)
Comment on attachment 9258561 [details] [diff] [review]
1749549-sidebarAbContextMenu-panel.patch

Review of attachment 9258561 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #9258561 - Flags: review?(alessandro) → review+
Target Milestone: --- → 98 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/e23883d2ce5b
Use the panel for the sidebarAbContextMenu. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.