Closed Bug 1750043 Opened 4 years ago Closed 4 years ago

Use a better method for getting content-length in Http3Stream.

Categories

(Core :: Networking, task, P2)

Product:
Core
Component:
Networking
Type:
task

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1750587

People

(Reporter: emilio, Assigned: dragana)

Details

(Whiteboard: [necko-triaged])

As mentioned in bug 1749957 comment 12 and following, using a trivial string find is not great and could be incorrect in some edge cases.

I'm not familiar with callers of this code that aren't UDP requests like the one in that bug, so I'm not sure how much it can cause correctness issues in practice.

From a quick skim at the code, Http3Stream has a back pointer to the http transaction which contains the parsed headers, and already uses it to get access to e.g. the host header in TryActivating().

Would such a thing but for content-length be doable? Presumably we'd need to normalize the headers here or so to what other necko code expects, somehow.

Assignee: nobody → dd.mozilla
Severity: -- → N/A
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [necko-triaged]
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
No longer depends on: 1749957
You need to log in before you can comment on or make changes to this bug.