1750587 - Use a different way to determine the end of the upload stream in Http3tream

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: Use a different way to determine the end of the upload stream.

This is similar to the nsHttpConnection approach.

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: Make sure that Content-Length header contains the correct number of bytes that will be sent using Http/3.

The patch adds a diagnostic assertion into Http3SStream code.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b722c1acb3e
Use a different way to determine the end of the upload stream. r=necko-reviewers,valentin

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5b722c1acb3e

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10c14d758c81
Make sure that Content-Length header contains the correct number of bytes that will be sent using Http/3. r=necko-reviewers,valentin

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/10c14d758c81

Comment 7

[Calixte Denizet (:calixte)]

There is one crash because of the added assertion:
https://crash-stats.mozilla.org/report/index/893af824-7907-44bd-9917-6a9d60220128

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Should the crash reports from the assertion (see comment 7) get a new bug? There are 13 crashes from 7+ devices.

Comment 10

[Dragana Damjanovic [:dragana]]

(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #9)

Should the crash reports from the assertion (see comment 7) get a new bug? There are 13 crashes from 7+ devices.

I will open another bug. The assertion is a sign that something is not using necko API correctly or, unlikely, the check is wrong. The second is unlikely because I would expect more failures in that case.

Comment 11

[Dragana Damjanovic [:dragana]]

I moved the crash to bug 1753002.