1750386 - help button not working in delete cert dialog

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Frank-Rainer Grahl (:frg)]

Timestamp: 15.01.2022, 19:33:10
Error: ReferenceError: gParams is not defined
Source File: chrome://communicator/content/helpSecurityOverlay.xul
Line: 38

Bug 1310961 removed the gParams variable it uses.
https://hg.mozilla.org/mozilla-central/rev/8c3384531cc0

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1750386-certdelhelp-25311.patch

Thought about using window arguments directly but like the typeFlag used as in the regression bug more. But can do otherwise.

[Approval Request Comment]
Regression caused by (bug #): bug 1310961
User impact if declined: defunct help button in cert delete dialog
Testing completed (on m-c, etc.): 2.533.11b1 pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9259242 [details] [diff] [review]
1750386-certdelhelp-25311.patch

[Triage Comment]
LGTM r/a=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/67e008c2f1fd
Use window.arguments to select correct help section in cert delete dialog. r=IanN

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/9a4a6e9aa8f6c247e651134533da48285de9f127
Use window.arguments to select correct help section in cert delete dialog. r=IanN a=IanN