Closed Bug 1750386 Opened 3 years ago Closed 2 years ago

help button not working in delete cert dialog

Categories

(SeaMonkey :: Help Viewer, defect)

defect

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey 2.95
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: frg, Assigned: frg)

Details

(Whiteboard: SM2.53.11)

Attachments

(1 file)

Timestamp: 15.01.2022, 19:33:10
Error: ReferenceError: gParams is not defined
Source File: chrome://communicator/content/helpSecurityOverlay.xul
Line: 38

Bug 1310961 removed the gParams variable it uses.
https://hg.mozilla.org/mozilla-central/rev/8c3384531cc0

Thought about using window arguments directly but like the typeFlag used as in the regression bug more. But can do otherwise.

[Approval Request Comment]
Regression caused by (bug #): bug 1310961
User impact if declined: defunct help button in cert delete dialog
Testing completed (on m-c, etc.): 2.533.11b1 pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Attachment #9259242 - Flags: review?(iannbugzilla)
Attachment #9259242 - Flags: approval-comm-release?
Attachment #9259242 - Flags: approval-comm-esr60?

Comment on attachment 9259242 [details] [diff] [review]
1750386-certdelhelp-25311.patch

[Triage Comment]
LGTM r/a=me

Attachment #9259242 - Flags: review?(iannbugzilla)
Attachment #9259242 - Flags: review+
Attachment #9259242 - Flags: approval-comm-release?
Attachment #9259242 - Flags: approval-comm-release+
Attachment #9259242 - Flags: approval-comm-esr60?
Attachment #9259242 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/67e008c2f1fd
Use window.arguments to select correct help section in cert delete dialog. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.95

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/9a4a6e9aa8f6c247e651134533da48285de9f127
Use window.arguments to select correct help section in cert delete dialog. r=IanN a=IanN

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: