Browser Action Popup is transparent.
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Tracking
(thunderbird_esr91 unaffected, thunderbird97? fixed)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr91 | --- | unaffected |
| thunderbird97 | ? | fixed |
People
(Reporter: TbSync, Assigned: TbSync)
Details
Attachments
(4 files)
actions.png
Moz-Regression points to
https://phabricator.services.mozilla.com/D133958
But that looks unsuspicious to me.
Hi. I'll attach a set of screenshot of this problem (using repro addon).
For detail description: I have confirmed this addon popup's transparent background issue on,
- Thunderbird 97.0b1
- 3 action types:
browser_actioncompose_actionmessage_display_action.
I wrote a sample demo addon as repro of this issue.
https://github.com/HiraokaHyperTools/ActionPopupTest
https://github.com/HiraokaHyperTools/ActionPopupTest/releases/download/v0.1/action_popup.xpi
|
||
Comment 3•4 years ago
|
||
Testing on Daily with the test XPI I see that the panel gets a style="--arrowpanel-background: rgba(0, 0, 0, 0);". Disabling this style shows the normal background from the theme.
|
Assignee | |
Comment 4•4 years ago
|
||
The root cause is that here:
https://searchfox.org/comm-central/rev/6bd44de06ffcfdd70c745ba757e966cf1f57ab08/mail/components/extensions/ExtensionPopups.jsm#181-185
someone is actually sending rgba(0,0,0,0) as background, instead of null, so somewhere defaults are injected.
|
|
Assignee | |
Comment 5•4 years ago
|
||
Probably related to:
https://bugzilla.mozilla.org/show_bug.cgi?id=1744749
|
|
||
Comment 6•4 years ago
|
||
Yes, porting https://hg.mozilla.org/releases/mozilla-beta/rev/85010d5acf5a#l1.12 and removing https://searchfox.org/comm-central/rev/ebb466e874faceafe7deeb9db812e426efae90f5/mail/components/extensions/ExtensionPopups.jsm#259 fixes it for me.
And adding <meta name="color-scheme" content="dark light"> in the <head> section of the test XPI makes it also follow the TB dark theme.
|
|
Assignee | |
Comment 7•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 8•4 years ago
•
|
||
The theme-able popup feature is sure worth a topicbox post. That is nice.
Doing a try run before requesting check-in.
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=904c46acb83cead97689c3f21f8f037a26c466bf
|
|
Assignee | |
Updated•4 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/0f97c4e63350
Port relevant parts of bug 1744749 to fix transparent action popups. r=Paenglab
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 10•4 years ago
|
||
Comment on attachment 9259646 [details]
Bug 1750495 - Port relevant parts of bug 1744749 to fix transparent action popups. r=Paenglab
[Approval Request Comment]
Regression caused by (bug #):
Changes in M-C: Bug 1744749
User impact if declined:
Transparent action popus in beta 97
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low.
|
||
Comment 11•4 years ago
|
||
Comment on attachment 9259646 [details]
Bug 1750495 - Port relevant parts of bug 1744749 to fix transparent action popups. r=Paenglab
[Triage Comment]
Approved for 97.0b3.
|
|
||
Comment 12•4 years ago
|
||
| bugherder uplift | ||
Thunderbird 97.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/2e8693de763d
|
||
Comment 13•4 years ago
|
||
Thank you, I have confirmed that the addon popup has background color, on Thunderbird 97.0b3!
Description
•