1750655 - 'Add Security Exception' dialog omits port number when trying to add CalDAV network calendar from server running on port 5006

Status: RESOLVED FIXED

(Thunderbird :: Security, defect)

Description

[Johannes]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:95.0) Gecko/20100101 Firefox/95.0

Steps to reproduce:

I'm using Thunderbird 78.14.0 on Ubuntu 20.04.3 LTS and want to add a CalDAV network calendar in a fresh profile.
The URL looks like this: https://server:5006/Tausch/Kalender/Kalender
The server is a Synology DSM (6.2.4-25556 Update 2) and it's using a self-signed certificate.

Actual results:

I get the 'Add Security Exception' dialog, but the Location omits the port number 5006, it just have: server
So when clicking 'Confirm Security Exception', the port number 443 is added to server.
Therefore there is no connection possible and the dialog pop ups again.

Expected results:

The 'Add Security Exception' dialog should not omit the port number.

Comment 1

[Magnus Melin [:mkmelin]]

78 is end of life since quite some time. Please upgrade.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1750655 - when adding security exceptions, both hostname and port should be included when non-standard. r=darktrojan

Comment 3

[Magnus Melin [:mkmelin]]

Johannes: please try this try build: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PkXBpgkbQC2fpcGAjjT7aQ/runs/0/artifacts/public/build/target.tar.bz2

Comment 4

[Johannes]

I tested the daily build and can confirm that it works now as expected!
Thanks a lot!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/64575e67552c
when adding security exceptions, both hostname and port should be included when non-standard. r=darktrojan

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9259506 [details]
Bug 1750655 - when adding security exceptions, both hostname and port should be included when non-standard. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): unclear if it is a regression. maybe from cert override re-work
User impact if declined: can't add cert exception, and confusing experience if try to do so
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low risk

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9259506 [details]
Bug 1750655 - when adding security exceptions, both hostname and port should be included when non-standard. r=darktrojan

[Triage Comment]
Approved for esr91

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 91.6.1:
https://hg.mozilla.org/releases/comm-esr91/rev/04c2a2c055df