Closed Bug 1750897 Opened 3 years ago Closed 3 years ago

VideoConfiguration should accept and store non-required properties

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox98 --- fixed

People

(Reporter: bradwerth, Assigned: bradwerth)

References

Details

Attachments

(3 files)

Bug 1750897 Part 1: Expand VideoConfiguration with optional properties.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1750897 Part 2: Include new VideoConfiguration properties in debug output.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1750897 Part 3: Update WPT expectations.
48 bytes, text/x-phabricator-request
Details | Review

Our IDL for VideoConfiguration only includes the required properties, whereas the WPT for MediaCapabilities includes all the ones from the spec. We need to store these additional properties so we can more accurately report what we support and what we don't support.

No longer blocks: 1749764
Blocks: 1751217
Blocks: 1749764
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/23bb922bfb93 Part 1: Expand VideoConfiguration with optional properties. r=media-playback-reviewers,alwu,webidl,smaug https://hg.mozilla.org/integration/autoland/rev/3ad3a7b2c12e Part 2: Include new VideoConfiguration properties in debug output. r=media-playback-reviewers,alwu

Backed out for causing wpt failures on decodingInfo.any.html

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-PASS | /media-capabilities/decodingInfo.any.worker.html | Test that decodingInfo rejects if the video configuration has an empty hdrMetadataType - expected FAIL
Flags: needinfo?(bwerth)

Sorry about missing that. Fix incoming.

Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b0b2efeaeb7d Part 1: Expand VideoConfiguration with optional properties. r=media-playback-reviewers,alwu,webidl,smaug https://hg.mozilla.org/integration/autoland/rev/ab9e34c80271 Part 2: Include new VideoConfiguration properties in debug output. r=media-playback-reviewers,alwu https://hg.mozilla.org/integration/autoland/rev/81a86e00f833 Part 3: Update WPT expectations. r=alwu
Flags: needinfo?(bwerth)

https://hg.mozilla.org/mozilla-central/rev/b0b2efeaeb7d
https://hg.mozilla.org/mozilla-central/rev/ab9e34c80271
https://hg.mozilla.org/mozilla-central/rev/81a86e00f833

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: