1750952 - Move selectors from reducers modules to selectors modules

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Currently, debugger's reducer modules are hosting many selector methods which are directly used by the React Components.

For example all these methods of the sources reducer:
https://searchfox.org/mozilla-central/rev/d4b9c457db637fde655592d9e2048939b7ab2854/devtools/client/debugger/src/reducers/sources.js#583-1036

It would probably help the long term maintenance of this by having a clearer split between:

• reducers, which only implement the update method
• selectors, which are querying the state with a particular layout for the queried data

Doing this might actually help revisit the selectors and improve their performance.
This would probably help highlight the number of selectors used, their inter-dependencies and help craft selectors that memoize more frequently.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1750952 - [devtools] Migrate all expressions selectors to a selector module.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1750952 - [devtools] Stop exposing all reducers from selectors.

Comment 3

[Alexandre Poirot [:ochameau]]

try run with all the patches:
https://treeherder.mozilla.org/jobs?repo=try&revision=6a9f97bfd8654052d3b99618ee6627b36f91275f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22568bcf2d59
[devtools] Migrate all expressions selectors to a selector module. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/4c536f66f404
[devtools] Stop exposing all reducers from selectors. r=bomsy

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/22568bcf2d59
https://hg.mozilla.org/mozilla-central/rev/4c536f66f404