1751851 - Move all simple selectors from reducers modules to selectors modules

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

See bug 1750952.
This is about selector functions currently hosted in the reducers folder:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/reducers

This bug aims to bulk move all the trivial reducers, while keeping distinct bugs for the complex ones like sources, breakpoints, ...

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1751851 - [devtools] Remove unused getFramework selector.

Only this jest test was using it.

The react component is using this one instead:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/actions/sources/symbols.js#26-28
which depends on tabs reducer's framework attribute, which uses the ast's getSymbols selector:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/components/shared/SourceIcon.js#44
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/utils/tabs.js#35-38

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1751851 - [devtools] Migrate all ast selectors to a selector module.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1751851 - [devtools] Migrate all event-listeners selectors to a selector module.

I'm also sorting the import from index.js in order to help the maintenance of this list.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1751851 - [devtools] Migrate all exceptions selectors to a selector module.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1751851 - [devtools] Migrate all file-search selectors to a selector module.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1751851 - [devtools] Migrate all preview selectors to a selector module.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1751851 - [devtools] Migrate all project-text-search selectors to a selector module.

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1751851 - [devtools] Migrate all quick-open selectors to a selector module.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1751851 - [devtools] Migrate all source-tree selectors to a selector module.

Comment 10

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1751851 - [devtools] Migrate all ui selectors to a selector module.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b3ac9c7faad
[devtools] Remove unused getFramework selector. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/a1dbb1bbd840
[devtools] Migrate all ast selectors to a selector module. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/d488d0622398
[devtools] Migrate all event-listeners selectors to a selector module. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/baee530c5d6a
[devtools] Migrate all exceptions selectors to a selector module. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/c888273eef09
[devtools] Migrate all file-search selectors to a selector module. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/52aba77f897e
[devtools] Migrate all preview selectors to a selector module. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/4ede7bf99a57
[devtools] Migrate all project-text-search selectors to a selector module. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/6588613b52df
[devtools] Migrate all quick-open selectors to a selector module. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/4737adc165d0
[devtools] Migrate all source-tree selectors to a selector module. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/1e42f62ff828
[devtools] Migrate all ui selectors to a selector module. r=bomsy

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1b3ac9c7faad
https://hg.mozilla.org/mozilla-central/rev/a1dbb1bbd840
https://hg.mozilla.org/mozilla-central/rev/d488d0622398
https://hg.mozilla.org/mozilla-central/rev/baee530c5d6a
https://hg.mozilla.org/mozilla-central/rev/c888273eef09
https://hg.mozilla.org/mozilla-central/rev/52aba77f897e
https://hg.mozilla.org/mozilla-central/rev/4ede7bf99a57
https://hg.mozilla.org/mozilla-central/rev/6588613b52df
https://hg.mozilla.org/mozilla-central/rev/4737adc165d0
https://hg.mozilla.org/mozilla-central/rev/1e42f62ff828