1751025 - Opacity CSS property does not affect <tspan> elements

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[taylorgratzer]

Attachment: Firefox bug report opacity.png

Steps to reproduce:

Create a <tspan> and apply a style with any value less than 1 for the CSS "opacity" property.

See: https://codepen.io/Nickardson/pen/MWEdmpr

Actual results:

The tspan will remain fully opaque, even with values of 0 opacity.

Expected results:

The tspan should become transparent.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Web Painting' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Alice0775 White]

I can reproduce the issue in Nightly98.0a1 but not in Firefox24.0

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cbb24a4a96af&tochange=d7553251cf43

Regressed by Bug 839955

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: testcase 1 (comparing opacity to fill-opacity and stroke-opacity)

Thanks for the bug report!

Side note: it does look like we honor fill-opacity and stroke-opacity on tspan elements, as shown in the lower two lines in this testcase. It's just opacity that we seem to ignore.

Comment 4

[Pascal Chevrel:pascalc]

Although it is technically a regression, that's a regression from Firefox 25 which was almost 10 years ago. I am removing the regression keyword as this bug doesn't need to be triaged during our regression triage meeting every week.

Comment 5

[Robert Longson [:longsonr]]

Note we pass https://wpt.fyi/results/svg/text/reftests/tspan-opacity-mixed-direction.svg?label=experimental&label=master&aligned because we also misrender the reference case.

Comment 6

[Robert Longson [:longsonr]]

Attachment: Bug 1751025 - Opacity CSS property should apply to all children of text elements r=jfkthame

Comment 7

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8af12d313fc5fef6e5ffac2ea6f2d53cbb529bd1

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a846d1b82b98
Opacity CSS property should apply to all children of text elements r=jfkthame

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39468 for changes under testing/web-platform/tests

Comment 10

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on opacity.svg

• backout: https://hg.mozilla.org/integration/autoland/rev/db64f743c0f0a1a66f19254aaec19d10e49382cd
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=CXx-nKABS2qpyXRUwJQnzA.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=a846d1b82b988ef7339ed9eeabec121b535109df
• failure log: https://treeherder.mozilla.org/logviewer?job_id=411939935&repo=autoland&lineNumber=38909

[task 2023-04-11T06:36:48.423Z] 06:36:48     INFO - TEST-START | /svg/text/reftests/opacity.svg
[task 2023-04-11T06:36:48.425Z] 06:36:48     INFO - PID 2846 | 1681195008424	Marionette	INFO	Testing http://web-platform.test:8000/svg/text/reftests/opacity.svg == http://web-platform.test:8000/svg/text/reftests/opacity-ref.svg
[task 2023-04-11T06:36:48.431Z] 06:36:48     INFO - PID 2846 | [Child 2862, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (MarionetteReftest, MarionetteReftestParent:reftestWait) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:57
[task 2023-04-11T06:36:48.495Z] 06:36:48     INFO - PID 2846 | [Child 2862, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (MarionetteReftest, MarionetteReftestParent:reftestWait) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:57
[task 2023-04-11T06:36:48.539Z] 06:36:48     INFO - PID 2846 | 1681195008538	Marionette	INFO	No differences allowed
[task 2023-04-11T06:36:48.627Z] 06:36:48     INFO - TEST-UNEXPECTED-FAIL | /svg/text/reftests/opacity.svg | Testing http://web-platform.test:8000/svg/text/reftests/opacity.svg == http://web-platform.test:8000/svg/text/reftests/opacity-ref.svg
[task 2023-04-11T06:36:48.627Z] 06:36:48     INFO - Found 266 pixels different, maximum difference per channel 1

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=94f5172fda64b528a45ee02886bee3170fd8806a

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26eed7e9843b
Opacity CSS property should apply to all children of text elements r=jfkthame

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/26eed7e9843b

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot