1751060 - Screenshots extension panel SVGs lost blue background color

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[Niklas Baumgardner [:niklas]]

The SVG images for full page and visible lost the blue background color.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1751060 - Add fallback color and removed st2 class for screenshots SVGs. r=sfoster!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1739209

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bbb1cb3fe4b
Add fallback color and removed st2 class for screenshots SVGs. r=sfoster

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2bbb1cb3fe4b

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9259804 [details]
Bug 1751060 - Add fallback color and removed st2 class for screenshots SVGs. r=sfoster!

Beta/Release Uplift Approval Request

• User impact if declined: Colors are black rather than blue/highlight-color on the "full page" and "visible page" buttons in the Screenshots UI
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Use the context menu or toolbarbutton to open Screenshots on any web page. The visible and full page buttons should be a black outline on a blue rectangle (or whatever the highlight color is for the current them)
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change to the SVG images. These are only used in this UI.
• String changes made/needed: None

Comment 7

[Sam Foster [:sfoster] (he/him)]

I think we could uplift this. Its very low risk and fixes a visual regression.

Comment 8

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 98.0a1 (2022-01-24) on Windows 10 x64, Ubuntu 20.04 x64 and on macOS 11.6.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9259804 [details]
Bug 1751060 - Add fallback color and removed st2 class for screenshots SVGs. r=sfoster!

Approved for 97.0b8.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e5b117f0a299

Comment 11

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 97.0b8 on Windows 10 x64, Ubuntu 20.04 x64 and on macOS 11.6.