Closed Bug 17511 Opened 26 years ago Closed 26 years ago

libjar extraction needs to verify CRC-32

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

All
Other
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dveditz, Assigned: samir_bugzilla)

Details

When a file is extracted from libjar it needs to verify the CRC-32 and return an error if it doesn't match. This is true for both the stream and extract-to-file forms.
In the case of extract to file an error should also result in deleting the file. In the stream case we can leave it up to the consumer of the stream.
Target Milestone: M12
Blocks: 17907
Blocks: 18471
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Fix checked in. For simple testcases see: http://puma/x Choose the Good CRC testcase which shoudl output a message from teh install script. The Bad CRC testcase is a copy of the same .xpi with the CRC-32 bits modified to be incorrect and hence the install script will not be extracted and won't run. Other forms of verification can be covered by using xpinstall to install a small file of a few bytes (say a single word text file with 4 unique chars) which tests handling of stored files (not compressed), and, larger files like dlls from a mozilla build.
Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall Engine
Status: RESOLVED → VERIFIED
Build 1999-12-12-09-M12(WIN), 1999-12-13-08-M12(MAC), 1999-12-13-08-M12(LINUX) Good on all platforms.
No longer blocks: 17907
No longer blocks: 18471
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.