1751560 - Incorrectly Formatted Menu Bar Items on macOS

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[ASF]

Attachment: Screenshot 2022-01-22 at 10.56.53.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:95.0) Gecko/20100101 Firefox/95.0

Steps to reproduce:

Option-Click (or right click) on the Firefox icon in the Dock while the application is running.

Actual results:

The context menu opens and lists items for "New window" and "New private window" without the proper capitalisation that is expected for macOS menu item labels.

Expected results:

The items should be capitalised appropriately as "New Window" and "New Private Window", following other applications on the platform and Apple's guidelines. For instance, Safari has the exact same two options with the expected capitalisation.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Cocoa' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Stephen A Pohl [:spohl]]

Mike, could you weigh in here? I believe these two menus were supposed to keep title casing, but were changed in bug 1682022.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1682022

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1751560 - Use title-cased File menu strings for macOS dock menu items. r?mhowell!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Whoops - yeah, this looks like an oversight on our part. Patch up.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f42acdeba31a
Use title-cased File menu strings for macOS dock menu items. r=mhowell

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f42acdeba31a

Comment 8

[:Gijs (he/him)]

Does this want beta uplift? Last beta gtb is in a few hours, and this looks pretty safe.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9260910 [details]
Bug 1751560 - Use title-cased File menu strings for macOS dock menu items. r?mhowell!

Beta/Release Uplift Approval Request

• User impact if declined: macOS users will find that some strings in the dock menu for Firefox don't match the casing conventions of the platform (Title Case).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We're changing the menu items to use the strings from the native File menu, which are properly cased. This does not require a string change - it's just a really simple string ID change.
• String changes made/needed: None.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9260910 [details]
Bug 1751560 - Use title-cased File menu strings for macOS dock menu items. r?mhowell!

Trivial fix switching us over to properly-cased strings. Approved for 97.0b9 and 91.6esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8158b8958d75

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9260910 [details]
Bug 1751560 - Use title-cased File menu strings for macOS dock menu items. r?mhowell!

nvm, this would need a different patch for ESR and it's probably not worth someone's effort to do so.