Closed Bug 1751640 Opened 3 years ago Closed 3 years ago

browser_ext_composeScripts.js, browser_ext_messageDisplayScripts.js broken, need to pass a frameId to TabBase._execute

Categories

(Thunderbird :: Add-Ons: Extensions API, defect)

Product:
Thunderbird
Component:
Add-Ons: Extensions API
Type:
defect

Tracking

(thunderbird_esr91 unaffected)

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
thunderbird_esr91 --- unaffected

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Regression)

Details

(Keywords: regression)

Bug 1736574 requires either frameId or allFrames to be set when calling TabBase._execute (and therefore executeScript, insertCSS or removeCSS). We haven't been doing that.

I'm going to add frameId: null here and two lines later. This should be sufficient, as I think it's very unlikely that message composition or message display would have frames (in fact I think it's blocked by various means).

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/145f98d1b9f9
Pass required frameId argument to TabBase._execute. rs=bustage-fix DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.