1751763 - Integrate with Firefox Relay

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P2)

Description

[Sergey Galich [:serg]]

Firefox Desktop + Firefox Relay = <3

Comment 1

[Sergey Galich [:serg]]

Attachment: WIP: Bug 1751763 - Firefox Relay integration

Depends on D155779

Comment 2

[Sergey Galich [:serg]]

Attachment: Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,#desktop-theme-reviewers,dao,sfoster,#geckoview-reviewers,jonalmeida

Comment 3

[Sergey Galich [:serg]]

Link to Figma https://www.figma.com/file/o7H2fSWeQFAWjBrSwDUxgO/Relay---Firefox-Integration-Explorations?node-id=1219%3A18051&t=mCa68xh1z0wXg0Sm-0

Comment 4

[Dimi Lee [:dimi]]

Attachment: WIP: Bug 1751763 - WIP telemetry to record Firefox Relay Integration related metrics

Comment 5

[Mike Kaply [:mkaply]]

Can someone provide more detail as to what's being done here? This bug doesn't have much detail.

We would definitely need policy to turn this off before it lands.

Comment 6

[Sergey Galich [:serg]]

:mkaply we are adding "Protect your email address" command to the list of autocomplete options of username on the sign up pages. Initially we will offer that to Firefox Account & Relay users, to avoid surprises.

Let me get back to you in Slack with details.

Comment 7

[Issam Mani [:issammani]]

Attachment: Bug 1751763 - Add relevant telemetry events to relay integration. r=#credential-management-reviewers!

Comment 8

[Sergey Galich [:serg]]

Attachment: data collection request.txt

Comment 9

[Chris H-C :chutten]

Comment on attachment 9306950 [details]
data collection request.txt

PRELIMINARY NOTES:

This data collection must be documented in a publicly-accessible way. Code generally isn't considered good enough to meet this standard.

For userPrefs this often takes the form of a line or two in the source docs. Please ensure you update the docs with the documentation about this data collection, as this data-review+ is conditional on that.

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :serg is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+, so long as the documentation is updated.

Comment 10

[Phabricator Automation]

Comment on attachment 9306819 [details]
Bug 1751763 - Add relevant telemetry events to relay integration. r=#credential-management-reviewers!

Revision D163911 was moved to bug 1804502. Setting attachment 9306819 [details] to obsolete.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9723d831f285
Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster

Comment 12

[Cosmin Sabou [:CosminS]]

Backed out changeset for causing geckoview failures on loginSelectAccept and relay browser-chrome failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=9723d831f2853db3e5b10dcfdcdb1b8fa64bee90&selectedTaskRun=VlBytt5eSTKrtXfdSBiwzA.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=398974095&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=398975142&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=398973881&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/5ca1f2d30af52ffaea32bbdfb3492ca33d9eed79

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2522b2da871e
Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Sergey, this is landing during the soft freeze and also adding new strings after string freeze. Can you please clarify what approvals this went through to do so?

Comment 15

[Iulian Moraru]

Backed out as per sgalich's request.

Backed out push

Backout link

When revisiting this, please take a look at Bug 1804967, it was regressed by this bug. I will close Bug 1804967 as invalid because browser_privacy_relayIntegration.js was added in this bug.

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2522b2da871e

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad94b64c18cb
Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida

Comment 18

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures on browser_startup_images.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/content/logos/relay.svg should have been shown. -

Comment 19

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #13)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2522b2da871e
Firefox Relay integration
r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,
jonalmeida

== Change summary for alert #36465 (as of Fri, 16 Dec 2022 10:31:47 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
3%	welcome loadtime	macosx1015-64-shippable-qr	cold fission webrender	46.33 -> 47.88	Before/After
2%	welcome loadtime	macosx1015-64-shippable-qr	cold fission webrender	46.40 -> 47.50	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36465

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8ae77a06639
Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida

Comment 21

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c8ae77a06639

Comment 22

[Sören Hentzschel]

How is page.os-auth.enabled related to the Firefox Relay integration? This option was enabled for Nightly users since May 2020 and disabled by this patch, without any comment in Bugzilla or Phabricator.

Comment 23

[Sergey Galich [:serg]]

Thanks for noticing and letting us know Sören. This is unintended change, we'll revert it soon.