context menu submenu highlight misalign
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox96 | --- | wontfix |
firefox97 | --- | wontfix |
firefox98 | --- | wontfix |
firefox99 | --- | verified |
People
(Reporter: lilydjwg, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Firefox/98.0
Steps to reproduce:
- switch to wayland and enable that for firefox
- get a context menu and move to a submenu
Actual results:
See attached screenshot. The top of submenu including margin or border or whatever is aligned with supermenu (or parent menu?)'s item. The items themselves are not aligned.
Expected results:
The items themselves should be aligned.
The round corner and top and bottom margins are only seen on Wayland in the default GTK theme, so it happens to firefox only after switching to Wayland.
I managed to get rid of the round corner and margins with the following GTK css, but Firefox's submenu is still off by one pixel (the gray border).
.csd menu {
border-radius: 0px;
padding: 0px;
}
.csd.popup decoration {
border-radius: 0px;
}
Comment 1•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Seems to also happen in XWayland / X11, what am I missing?
Your GTK theme is different than default? This should be caused by the difference of the GTK theme on different platforms.
Comment 4•3 years ago
|
||
Gnome Wayland + Xwayland, Adwaita-dark, Debian Testing
Also reproducible with Xwayland.
The second popup needs to be a few more pixels to the top, so that both blue bars are in one line.
I just checked that the one-pixel difference also happens on xwayland. It was just not that obvious to notice.
Comment 6•3 years ago
•
|
||
That's much more than 1 pixel. It's more like the padding-top from the submenu needs to be subtracted from its "top", so that both blue bars are in one line (flushness).
bad is when both blue bars are not in one line.
mozregression --good 90 --bad 2022-01-24
9:14.64 INFO: Last good revision: 184d074f07d7d64f5aad4ccb7b683b2e937d3548
9:14.64 INFO: First bad revision: 8af885e0f3dd5b4dadc42d270f13f009092873c4
9:14.64 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=184d074f07d7d64f5aad4ccb7b683b2e937d3548&tochange=8af885e0f3dd5b4dadc42d270f13f009092873c4
8af885e0f3dd5b4dadc42d270f13f009092873c4 Emilio Cobos Álvarez — Bug 1738084 - Make popups on Linux have shadows. r=stransky
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 7•3 years ago
|
||
Updated•3 years ago
|
Comment 9•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Updated•3 years ago
|
Comment 10•3 years ago
|
||
I have reproduced this issue using Firefox 98.0a1 (2022.01.25) on Ubuntu 20 x64 with wayland enabled.
I can confirm this issue is fixed, I verified using Firefox 99.0 and Fx 102.0b1 on Ubuntu 20.04 x64 with wayland enabled.
Description
•