1751959 - Switch back to using a single mark stack

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco)]

We changed to use separate mark stack for black and gray marking work in bug 1580888. However this is no longer required due to changes to weakmap marking in bug 1717553. Moving back to a single stack is a simplification that could also decrease memory use.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1751959 - Part 2: Remove the auxillary mark stack and use a single stack for both black and gray marking r?sfink

Comment 2

[Jon Coppeard (:jonco)]

This patch caused assertion failures in weak map marking, investigating.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1751959 - Part 1: Make weak map marking do gray marking after black r?sfink

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fde18b7f9e55
Part 1: Make weak map marking do gray marking after black r=sfink
https://hg.mozilla.org/integration/autoland/rev/26438f963a5f
Part 2: Remove the auxillary mark stack and use a single stack for both black and gray marking r=sfink

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/fde18b7f9e55
https://hg.mozilla.org/mozilla-central/rev/26438f963a5f

Comment 6

[Andrej (:aglavic)]

== Change summary for alert #33187 (as of Fri, 04 Feb 2022 23:43:34 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	Base Content JS	linux1804-64-shippable-qr		1,818,020.67 -> 1,785,304.00
2%	Base Content JS	linux1804-64-shippable-qr		1,817,990.33 -> 1,785,208.00
2%	Base Content JS	windows10-64-2004-shippable-qr		1,819,320.00 -> 1,786,648.00
2%	Base Content JS	macosx1015-64-shippable-qr		1,846,616.00 -> 1,813,912.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33187