1752051 - Pressing `Esc` key does not cancel editing contact in new Address Book (highly inconvenient for keyboard dependent users); needs confirmation dialog

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect, P2)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #1752042 +++

I filed this separately from similar bug 1752042 for Enter key behaviour because ideally we'll want to implement the confirmation at the same time as restoring Esc key behaviour. Otherwise Esc could be enabled there, too.

Seen on 98.0a1 (2022-01-25) (64-bit), Win10

STR:

• Edit a contact in ("new") Address Book
• Fill a random field
• Change your mind (say you want to save the contact from message reader instead)
• Press Esc key with focus in a field to trigger the Cancel button
• Try to cancel editing using keyboard only (!)
• Hit Cancel button.

Actual results:

• Pressing Esc key does nothing with focus in a field like Email
• Canceling contact editing via keyboard requires pressing Tab key up to 37 (!) times.
• Cancel does not confirm if you want to save your changes.

Expected results:

• Pressing Esc from any field should trigger Cancel button as it used to - that's how Escape buttons work in dialogs, and this is essentially still a modal dialog as Magnus correctly pointed out. This also avoids several dozens of repetititive keypresses for keyboard users including the blind.
• Cancel should confirm if you want to save your changes. We want to avoid contact dataloss for accidental keypresses of Esc (e.g. when you accidentally press Esc twice to close a dropdown). Voluntarily abandoning edits to a contact should be a rather rare/unlikely scenario, so better safe than sorry. We also ask for editing events (depending on method, bug on record).

Comment 1

[Thomas D. (:thomas8)]

P2/S2 because for keyboard dependent users like the blind, having to press Tab up to 37 times will be living hell.

Comment 2

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

Fixed in bug 1752042.