1752359 - backout 3rd party panel bypass for site permissions

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, task, P1)

Description

[Shane Caraveo (:mixedpuppy)]

This backs out https://phabricator.services.mozilla.com/D131318

Since that patch landed long enough ago, a fresh backout patch will be added here.

Comment 1

[Shane Caraveo (:mixedpuppy)]

[Tracking Requested - why for this release]: This will need to be uplifted so adding tracking

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1752359 remove 3rd party panel bypass for site permissions addons

This is a backout of https://phabricator.services.mozilla.com/D131318

Comment 3

[Ryan VanderMeulen (PTO, back 6-April)]

Would be good if we could get this into today's b9 build today still.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9261068 [details]
Bug 1752359 remove 3rd party panel bypass for site permissions addons

Beta/Release Uplift Approval Request

• User impact if declined: 3rd party install panel is not shown for site permission (webmidi) addons
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: QA will modify the test plan to include the panel
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This backs out a patch and re-introduces well-tested and used code paths to show the install panel
• String changes made/needed: none

Comment 5

[Ryan VanderMeulen (PTO, back 6-April)]

Comment on attachment 9261068 [details]
Bug 1752359 remove 3rd party panel bypass for site permissions addons

Straight backout of what landed in the original bug. Approved for 97.0b9.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81ff9bb44fc8
remove 3rd party panel bypass for site permissions addons r=robwu

Comment 7

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-beta/rev/29d9122048c1

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/81ff9bb44fc8

Comment 9

[Alex Cornestean]

Hello,

Verified the fix on the latest Nightly(98.0a1/20220128094730) and Beta (97.0b9/20220127193706) under Windows 10 x64 and Ubuntu 16.04 LTS.

The 3rd party panel is now displayed when triggering the installation of site permission add-ons with valid install origins, confirming the fix.

For further details, see the attached screenshot.

Comment 10

[Alex Cornestean]

Attachment: 2022-01-28_08h43_09.png