backout 3rd party panel bypass for site permissions
Categories
(Toolkit :: Add-ons Manager, task, P1)
Tracking
()
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
(Whiteboard: [addons-jira])
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
33.98 KB,
image/png
|
Details |
This backs out https://phabricator.services.mozilla.com/D131318
Since that patch landed long enough ago, a fresh backout patch will be added here.
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
[Tracking Requested - why for this release]: This will need to be uplifted so adding tracking
Assignee | ||
Comment 2•2 years ago
|
||
This is a backout of https://phabricator.services.mozilla.com/D131318
Assignee | ||
Comment 4•2 years ago
|
||
Comment on attachment 9261068 [details]
Bug 1752359 remove 3rd party panel bypass for site permissions addons
Beta/Release Uplift Approval Request
- User impact if declined: 3rd party install panel is not shown for site permission (webmidi) addons
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: QA will modify the test plan to include the panel
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This backs out a patch and re-introduces well-tested and used code paths to show the install panel
- String changes made/needed: none
Assignee | ||
Updated•2 years ago
|
Comment 5•2 years ago
|
||
Comment on attachment 9261068 [details]
Bug 1752359 remove 3rd party panel bypass for site permissions addons
Straight backout of what landed in the original bug. Approved for 97.0b9.
Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/81ff9bb44fc8 remove 3rd party panel bypass for site permissions addons r=robwu
Comment 7•2 years ago
|
||
bugherder uplift |
Comment 8•2 years ago
|
||
bugherder |
Comment 9•2 years ago
|
||
Hello,
Verified the fix on the latest Nightly(98.0a1/20220128094730) and Beta (97.0b9/20220127193706) under Windows 10 x64 and Ubuntu 16.04 LTS.
The 3rd party panel is now displayed when triggering the installation of site permission add-ons with valid install origins, confirming the fix.
For further details, see the attached screenshot.
Comment 10•2 years ago
|
||
Updated•2 years ago
|
Description
•