1752441 - Change the "<engine> Suggestions" group label so that "suggestions" is lowercase

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Content has requested we change the "<engine> Suggestions" group label so that "suggestions" is lowercase because it describes a category rather than a branded feature. This came up in the context of best match and they'd like it alongside the best match MVP in 99, which shouldn't be a problem.

The label's string is urlbar-group-search-suggestions. The comment says it should use title case, which is now incorrect, so it needs to be updated too.

The Fluent docs say there's generally no need to change the ID of a string in this case, but it also talks about a gray area, and I think to be on the safe side we should change it. Other languages where case is relevant should also use lowercase and they'll need to be updated.

Daisuke, do you have time to work on this?

Comment 1

[Daisuke Akatsuka (:daisuke)]

Sure!

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1752441: Change search suggestion group label.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e67b3277eda4
Change search suggestion group label. r=adw,fluent-reviewers,kpatenio,flod

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e67b3277eda4

Comment 5

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified in Fx101.0a1 and Fx100.0b5 on Windows 10 and Ubuntu 20.04. The label is correctly displayed with the lowercase 's'.