1753252 - about:processes table is not keyboard accessible

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect, P3)

Description

[Morgan Reschenberg [:morgan]]

STR:

1. open about:performance
2. click a row in the table
3. hit up arrow

Expected:
The selected row changes

Actual:
Nothing happens

Note, if you hit down arrow, the page will scroll and the selected row will change to whatever item is now under the mouse. This doesn't satisfy the keyboard accessibility requirement.

4. From a selected row, hit tab

Expected:
The "X" button for that row is selected

Actual:
Focus moves in the firefox UI

The disclosure arrow, where present, should also be focusable

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:florian, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Florian Quèze [:florian]]

(In reply to Morgan Reschenberg [:morgan] from comment #0)

Note, if you hit down arrow, the page will scroll and the selected row will change to whatever item is now under the mouse.

Afaik the selected row doesn't change when using the arrow keys, the hovered row changes.

Currently nothing is keyboard accessible in about:performance (nor about:processes).

In addition to making the arrow and tab keys work, we should ensure moving the selection from the keyboard stops the re-sorting the same way moving the mouse does, otherwise trying to change the selection in a list that has a constantly changing order will be painful.

Bug 1498189 already has 2 duplicates, but I'm hesitant to mark this one as duplicate, because there's a better description here.

I'm hoping about:processes will replace about:performance soon. The code is similar in both, but fixing about:processes seems more useful.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, [access-s2].
:florian, could you consider increasing the severity?

For more information, please visit auto_nag documentation.

Comment 4

[Florian Quèze [:florian]]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #3)

The severity field for this bug is set to S3. However, the accessibility severity is higher, [access-s2].
:florian, could you consider increasing the severity?

No, the next step would IMO be to remove about:performance entirely in favor of about:processes (which is now the page exposed from the UI).

Comment 5

[Florian Quèze [:florian]]

Mass closing about:performance bugs as about:performance has been removed in bug 1836191 in favor of about:processes which displays more accurate data. If this bug still applies to about:processes, feel free to reopen and change the summary.

Comment 6

[Anna Yeddi [:ayeddi]]

Thank you, :florian, for bringing it up! Since the issue is still present on the about:processes page, reopening this bug and providing updated description below:

STR:

1. open about:processes
2. click a row in the table
3. hit up arrow
   1. Expected:
      1. The selected row changes
   2. Actual:
      1. Nothing happens
      2. Note, if you hit down arrow, the page will scroll and the selected row will change to whatever item is now under the mouse. This doesn't satisfy the keyboard accessibility requirement.
4. From a selected row, hit tab
   1. Expected:
      1. The Profile all threads in this process for 5 seconds (if present) or X button for that row is selected (focusability of these buttons is tracked in the bug 1786140)
   2. Actual:
      1. Focus moves to the first > disclosure arrow or the table and continue moving between disclosure buttons only (the twisty disclosure button is focusable and actionable with keyboard, bug 1753251)

Comment 7

[Anna Yeddi [:ayeddi]]

The Profile all threads... and X kill process buttons' accessibility is addressed in the bug 1786141.

In this bug, we need to cover table row headers' a11y (similar to the bug 1786894).

Comment 8

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1753252 - Make sortable table headers on about:processes accessible. r=Jamie,emilio,#desktop-theme-reviewers

Including the sortable table headers into the keyboard focus order, providing them with a role and full functionality of a button, as well as ensuring they are communicating their possibility of being sorted and update this sortable state accordingly.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7db8486b60cf
Make sortable table headers on about:processes accessible. r=Jamie,desktop-theme-reviewers,emilio

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7db8486b60cf