1854228 - Temporarily disable some Tier 2 a11y_checks for Desktop UI

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[Anna Yeddi [:ayeddi]]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with fail-if condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved. A separate task to investigate the failed Tier 2 a11y_checks will be filed for an appropriate component.

Tests affected:

browser/base/content/test/backforward/browser_history_menu.js	Node is not accessible via accessibility API	navigator-toolbox	toolbox	
browser/base/content/test/popupNotifications/browser_popupNotification_checkbox.js	Node is not accessible via accessibility API		label	checkbox-label
browser/base/content/test/protectionsUI/browser_protectionsUI.js	Node is not accessible via accessibility API	protections-popup-mainView-panel-header	box	panel-header panel-header-with-info-button
browser/base/content/test/protectionsUI/browser_protectionsUI_milestones.js	Interactive elements must be labeled	protections-popup-milestones-content	toolbarbutton	subviewbutton
browser/base/content/test/tabPrompts/browser_auth_spoofing_url_drag_and_drop.js	Node is not accessible via accessibility API	urlbar-input-container	hbox	
browser/base/content/test/tabs/browser_overflowScroll.js	Node is not focusable via the accessibility API	scrollbutton-down	toolbarbutton	
browser/base/content/test/tabs/browser_overflowScroll.js	Interactive elements must be labeled	scrollbutton-down	toolbarbutton	
browser/base/content/test/tabs/browser_overflowScroll.js	Node is not focusable via the accessibility API	scrollbutton-up	toolbarbutton	
browser/base/content/test/tabs/browser_overflowScroll.js	Interactive elements must be labeled	scrollbutton-up	toolbarbutton	
browser/base/content/test/tabs/browser_overflowScroll.js	"Scrolled one page of tabs with a double click - Got 193, expected 117
"			
browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarEmpty.js	Node is not accessible via accessibility API		html:a	text-link
browser/base/content/test/forms/browser_selectpopup_large.js	Interactive elements must be labeled	ContentSelectDropdown	menulist	
browser/base/content/test/forms/browser_selectpopup_searchfocus.js	Interactive elements must be labeled		input	
browser/base/content/test/forms/browser_selectpopup_toplevel.js	Interactive elements must be labeled		select	
browser/base/content/test/permissions/browser_permissions.js	Node is not accessible via accessibility API	identity-permission-box	box	identity-box-button
browser/base/content/test/general/browser_accesskeys.js	Interactive elements must be labeled	chromebutton	button	

toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_show_threads.js	Node is not accessible via accessibility API		TD	action-icon close-icon
toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_show_frames_without_threads.js	Node is not accessible via accessibility API		TD	action-icon close-icon
toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_show_all_frames.js	Node is not accessible via accessibility API		TD	action-icon close-icon
toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_selection.js	Node is not accessible via accessibility API		TR	process
toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_selection.js	Node is not accessible via accessibility API		TR	window
toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_selection.js	Node is not accessible via accessibility API		TR	thread-summary
toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_selection.js	Node is not accessible via accessibility API		TR	thread
toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_default_options.js	Node is not accessible via accessibility API		TD	action-icon close-icon

Jobs affected:

1. test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-${1-7} (Try run)

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1854228 - Temporarily fail-if some Tier 2 a11y_checks for Desktop UI. r=mconley,Jamie

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with fail-if condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved. A separate task to investigate the failed Tier 2 a11y_checks will be filed for an appropriate component.

Related bugs:

• Disabling tests: meta bug 1848402
• Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Desktop UI bug 1854233
• Explore capturing click events for a11y_checks: bug 1692110

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Disability Access APIs' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3d5c1ba2a84
Temporarily disable some Tier 2 a11y_checks for Desktop UI. r=mconley

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c3d5c1ba2a84

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out for causing multiple tier 2 failures on
Backout link
Push with failures

https://bugzilla.mozilla.org/show_bug.cgi?id=1857672
https://bugzilla.mozilla.org/show_bug.cgi?id=1857666
https://bugzilla.mozilla.org/show_bug.cgi?id=1857664
https://bugzilla.mozilla.org/show_bug.cgi?id=1857665
https://bugzilla.mozilla.org/show_bug.cgi?id=1857707

Comment 6

[Anna Yeddi [:ayeddi]]

New test results (Try):

FAIL	browser/base/content/test/popupNotifications/browser_popupNotification_checkbox.js	Node is not accessible via accessibility API		label	checkbox-label
PASS	browser/base/content/test/webextensions/browser_permissions_installTrigger.js	We expect at least one assertion to fail because this test file is marked as fail-if in the manifest

Comment 7

[Anna Yeddi [:ayeddi]]

New test failure: (Try):

FAIL	browser/base/content/test/permissions/browser_site_scoped_permissions.js	Node is not accessible via accessibility API	identity-permission-box	box	identity-box-button

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/172cab56babc
Temporarily fail-if some Tier 2 a11y_checks for Desktop UI. r=mconley

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/172cab56babc