1753610 - Address Autofill doorhanger is not displayed when submitting a form

Status: NEW

(Toolkit :: Form Autofill, defect, P3)

Description

[Simona Badau, Desktop QA]

Affected Versions:

Nightly 98.0a1

Tested on:

MacOS 11.6
Windows 10

Preconditions:

browser.search.region US,CA
extensions.formautofill.addresses.enabled true
extensions.formautofill.supportedCountries US,CA
extensions.formautofill.addresses.capture.enabled true

Steps to reproduce:

1. Navigate to https://luke-chang.github.io/autofill-demo/basic.html?
2. Fill in manually all the info and submit the form.

Expected Results:

The Address Autofill Save Doorhangher should be displayed with the option to save the address.

Actual Results:

The Address Autofill Save Doorhangher is not displayed.

Notes:

Severity: S3 severity.
Reproducible on both CA and the US builds.

Comment 1

[Tim Giles [:tgiles]]

Alright, I think I know what's going on here. So the first time an address form is submitted, with address capture enabled, we will display the "firstTimeUse" doorhanger which says "Nightly now saves address so you can fill forms faster.". By showing this doorhanger, we then set the ADDRESSES_FIRST_TIME_USE_PREF to false so we won't display the "firstTimeUser" doorhanger again. However, this means there's a chance we never initialize a doorhanger for address capture when an address form is submitted, because the else branch after an address capture has been used for the first time is just a telemetry call.

Given that a manually filled form doesn't have a stored GUID associated with it, we end up in a branch where we don't initialize doorhanger for address capture and so we do nothing in this situation. I suppose the remedy is to initialize the doorhanger in the else branch where we make the telemetry call and handle the doorhanger action there as well.