1753942 - Save some cycle in console

Status: RESOLVED FIXED

(DevTools :: Console, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Looking at profiles, there are small things showing up that we could avoid doing

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1753942 - [devtools] Remove MessageContainer defaultProps. r=dthayer.

The getter was showing up in a profile although it doesn't bring any value and
can safely be removed.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1753942 - [devtools] Check isNewMessageEvaluationResult through visibleMessages.r=dthayer.

We're checking if the last message is the result of an evaluation in ConsoleOutput
so we can scroll to the bottom.
But in order to do that, we're turning the messages map into an array, only to get
its last element, which was showing up in profiles.
We can retrieve the last added message id through visibleMessages as evaluation
and their results are never filtered.

Depends on D137986

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ca526bd1f7a
[devtools] Remove MessageContainer defaultProps. r=dthayer.
https://hg.mozilla.org/integration/autoland/rev/6955b2d62aa9
[devtools] Check isNewMessageEvaluationResult through visibleMessages.r=dthayer.

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4ca526bd1f7a
https://hg.mozilla.org/mozilla-central/rev/6955b2d62aa9