1776262 - Console keeps scrolling down

Status: VERIFIED FIXED

(DevTools :: Console, defect, P1)

Description

[drmccoy]

My problem is the opposite of https://bugzilla.mozilla.org/show_bug.cgi?id=1760910 . Basically, I scroll up in the JavaScript console to inspect data, but the console keeps forcibly scrolling to the bottom.

I think I've found why it does that. I see this happening when having the console pulled up in the virtual tabletop "Foundry VTT", which does a periodic (every second XHR to /api/status). Every time the XHR happens, the console is forced to the bottom.

However, this only happens when the XHR are filtered away using the selector thingy at the top-right of the dev tools. Basically, it seems that when the XHR are not filtered away, the console correctly checks that, yes, the user manually scrolled to up, so we don't want to force them down; but when the XHR are filtered away, that check doesn't happen, so the console is forced to the bottom even though the new message isn't even shown.

Unfortunately, I don't think I can offer an easy way for someone else to reproduce this issue, save using Foundry VTT itself.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: console_pinned_bottom_xhr.html

Hello drmccoy, thanks a lot for the report
I think I was able to narrow down the issue

Steps to reproduce

1. Go to https://ffx-devtools-console-stuck-bottom-evaluation-xhr.glitch.me/
2. Open the console
3. Evaluate 1 + 1
4. Try to scroll up

Expected results

You can scroll up fine

Actual results

The console keep scrolling back to the bottom

---

This only seems to happen when the last displayed message in the list is an evaluation result, so if a new log comes in, it will "unstuck" the scroll.

Can you confirm drmccoy ?

Comment 2

[drmccoy]

Yes, exactly, I can confirm.

(In your example, I also had to filter out Errors because of CORS stuff, though, but that changes nothing of the result. Also, now my IP seems to be(temporarily?) blocked with 429 Too Many Requests, so I'm answering via mobile LTE now)

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to drmccoy from comment #2)

Yes, exactly, I can confirm.

Great!

(In your example, I also had to filter out Errors because of CORS stuff, though, but that changes nothing of the result. Also, now my IP seems to be(temporarily?) blocked with 429 Too Many Requests, so I'm answering via mobile LTE now)

Yeah sorry about that, I put the test page on Glitch instead, there shouldn't be error anymore

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Okay so that's because of this change I made https://hg.mozilla.org/mozilla-central/rev/6955b2d62aa9a2bd9f803439f28cd1e984ddf850
we shouldn't check this through visible messages, as the "last displayed message" can be true for various reasons, and not only that we just displayed the result

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1753942

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1776262 - [devtools] Fix stuck to bottom console output. r=jdescottes.

When the last visible message was an evaluation result
but the last message in the store was something else,
the console would trigger the pin-to-bottom behavior.
This is fixed by checking if the last message in the
store (and not the last visible message) is a result.
A test case is added to make sure we don't regress.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efab979fdd37
[devtools] Fix stuck to bottom console output. r=jdescottes.

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/efab979fdd37

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9282755 [details]
Bug 1776262 - [devtools] Fix stuck to bottom console output. r=jdescottes.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is an extremely annoying bug, making the webconsole, one of the most used panel in DevTools, misbehave. It would be unbearable for developers using ESR to suffer from this until next ESR is released
• User impact if declined: When using the console, user can't scroll up on some relatively easy to hit condition
• Fix Landed on Version: 103
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small DevTools only change + automated test

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9282755 [details]
Bug 1776262 - [devtools] Fix stuck to bottom console output. r=jdescottes.

Approved for 102.1esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/70254fba3bdc

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9282755 [details]
Bug 1776262 - [devtools] Fix stuck to bottom console output. r=jdescottes.

Beta/Release Uplift Approval Request

• User impact if declined: When using the console, user can't scroll up on some relatively easy to hit condition
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Go to https://ffx-devtools-console-stuck-bottom-evaluation-xhr.glitch.me/

1. Open the console
2. Evaluate 1 + 1
3. Try to scroll up

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small DevTools only change + automated test
• String changes made/needed:
• Is Android affected?: No

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9282755 [details]
Bug 1776262 - [devtools] Fix stuck to bottom console output. r=jdescottes.

Approved for 102.0.1, thanks.

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-release/rev/93c0bb82ed04

Comment 15

[Monica Chiorean]

I was able to reproduce the issue on Win10 using build 103.0a1(20220623190323) and steps from comment #1.
Verified as fixed on Win10/Ubuntu20.4/Mac 10.13 using Beta 103.0b4(20220703190044).

Comment 16

[Monica Chiorean]

Verified as fixed on Win10/Mac10.13/Ubuntu20.4 using 102.0.1(20220705093820).

Comment 17

[Monica Chiorean]

On build 102.1.0esr (20220630085807) from https://treeherder.mozilla.org/jobs?repo=mozilla-esr102 issue is fixed on Win10/Ubuntu20.4.

Comment 18

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-esr102/rev/f9e8276b397e3e0632133c94a83bd51603044fc4 FIREFOX_ESR_102_0_X_RELBRANCH

Comment 19

[Monica Chiorean]

Verified as fixed on Win10/Mac10.13/Ubuntu20.4 using build 102.0.1esr(20220711174428).