1753968 - comm-central perma: FATAL ERROR: AsyncShutdown timeout in IOUtils: waiting for profileBeforeChange IO to complete Conditions: [{"name":"CrashMonitor: Writing notifications to file after receiving profile-before-change and awaiting all checkpoints written

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=366920604&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/XIRzgHeaTRewvAhI3X00og/runs/0/artifacts/public/logs/live_backing.log

---

FATAL ERROR: AsyncShutdown timeout in IOUtils: waiting for profileBeforeChange IO to complete Conditions: [{"name":"CrashMonitor: Writing notifications to file after receiving profile-before-change and awaiting all checkpoints written","state":{"profile-after-change":true,"final-ui-startup":true,"sessionstore-windows-restored":true,"quit-application-granted":true,"quit-application":true,"profile-change-net-teardown":true,"profile-

Comment 1

[Magnus Melin [:mkmelin]]

From https://hg.mozilla.org/mozilla-central/rev/ecb12fc81f7a346e7e7915e140ac12ff32a98593

Comment 2

[Geoff Lankow (:darktrojan)]

The crash monitor is waiting for a sessionstore-final-state-write-complete notification we never send, because the code that sends it is in browser. I think we can send it whenever we like (as long as it's after the observer is set up) and the problem will go away.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1753968 - Emit sessionstore-final-state-write-complete when quitting. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0ac31b142f25
Emit sessionstore-final-state-write-complete when quitting. r=mkmelin a=me

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9262793 [details]
Bug 1753968 - Emit sessionstore-final-state-write-complete when quitting. r=mkmelin

[Approval Request Comment]
Needed to stop the shutdown crash. There may be more coming if I can figure out why the last few tests are still crashing.

Comment 6

[Geoff Lankow (:darktrojan)]

I should not have let this bug close. There's still a few tests directories which fail and I don't know why, off the top of my head they are:

• mail/components/extensions/test/browser
• mail/test/browser/cloudfile
• mail/test/browser/composition

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9262793 [details]
Bug 1753968 - Emit sessionstore-final-state-write-complete when quitting. r=mkmelin

[Triage Comment]
Confirmed that the shutdown crash is gone on 2022-02-09 Daily build Linux64.
Approved for 98.0b1.

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 98.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/2d10e8aeae1e

Comment 10

[Intermittent Failures Robot]

6 failures in 3711 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 5
• try: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1
• linux1804-64-qr: 4
  • debug: 4
• windows10-64-2004-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1753968&startday=2022-02-07&endday=2022-02-13&tree=all

Comment 11

[Wayne Mery (:wsmwk)]

t.matsuu, your crashes are still gone on nightly?

Comment 12

[Takanori MATSUURA]

(In reply to Wayne Mery (:wsmwk) from comment #11)

t.matsuu, your crashes are still gone on nightly?

I cannot reproduce with the latest Daily build.
Last crash report on my Thunderbird Daily is 2022-02-10 04:04:34 UTC with Build ID 20220208101846.

2 of my crashes are [@ log2f ]
UUID, Build ID
bp-9ad68201-5c9c-4fc7-84d1-6fbf11220208, 20220207102808
bp-1153a1dc-8142-487f-9a16-3e9b21220208, 20220207102808

4 of those are [@ static XPCWrappedNative::CallMethod ]
UUID, Build ID
bp-60d71a7a-ba1f-42f7-b2d1-fcfdb1220208, 20220208101846
bp-b71cae45-fc28-4188-ab86-438991220208, 20220208101846
bp-02e9abe7-3a55-47e9-aa1e-6e0691220209, 20220208101846
bp-64f928bf-3a37-4a8d-a0e6-c35cf1220210, 20220208101846

Comment 13

[Geoff Lankow (:darktrojan)]

For the record, the patch here was backed out in bug 1755838. Some other change appears to have fixed the crashing.
https://hg.mozilla.org/comm-central/rev/f6774cc233496c86a754bffc96df395ac1eaffe1