1754186 - Download LDAP directory locally and switch to offline -> delete ldap file

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[adrien.rybarczyk]

Attachment: downloadOK.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36

Steps to reproduce:

1. Download a LDAP directory
2. Wait for the end of the replication
3. Switch to offline

Actual results:

The LDAP file, which has just been downloaded and created, is deleted.

Expected results:

The file is not deleted.

In LDAPReplicationService.jsm, there is no connection closure after a success.
This is why, if another event is triggered (e.g. going offline), it will apply the associated action (deleting the file).

Comment 1

[adrien.rybarczyk]

Attachment: switchOffline.PNG

Comment 2

[Magnus Melin [:mkmelin]]

Ping, please have a look.

Comment 3

[Ping Chen [:rnons] (away)]

Attachment: Bug 1754186 - Prevent LDAP replication file being removed after going offline. r=mkmelin

Clean up in _done should only be run once.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2cb433ab0393
Prevent LDAP replication file being removed after going offline. r=mkmelin

Comment 5

[Ping Chen [:rnons] (away)]

Comment on attachment 9262956 [details]
Bug 1754186 - Prevent LDAP replication file being removed after going offline. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1696625
User impact if declined: Going offline immediately after replicating a LDAP address book will delete the sqlite db file
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9262956 [details]
Bug 1754186 - Prevent LDAP replication file being removed after going offline. r=mkmelin

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 98.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/ebb089431f0f

Comment 8

[Rob Lemley [:rjl]]

Ping, this patch will not apply on c-esr91 as is. Could you take a look?

Comment 9

[Ping Chen [:rnons] (away)]

Attachment: 1754186-esr91.patch

Rebase to esr91, only differences are the file paths.

[Approval Request Comment]
Regression caused by (bug #): bug 1696625
User impact if declined: Going offline immediately after replicating a LDAP address book will delete the sqlite db file
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9269163 [details] [diff] [review]
1754186-esr91.patch

[Triage Comment]
Approved for esr91

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 91.8.0:
https://hg.mozilla.org/releases/comm-esr91/rev/8de3ca578bf9