1754195 - Use the active tab view in nightly only

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task)

Description

[Julien Wajsberg [:julienw]]

The active tab view has issues. Let's not use it by default in builds other than Nightly.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: Bug 1754195 - [profiler] Use the active tab view in nightly only r=canaltinova

Comment 2

[Julien Wajsberg [:julienw]]

Try: https://treeherder.mozilla.org/jobs?repo=try&revision=bbb435594f558471307748fb16a5739cbf5a4c20

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 9262864 [details]
Bug 1754195 - [profiler] Use the active tab view in nightly only r=canaltinova

Beta/Release Uplift Approval Request

• User impact if declined: User of the profiler from the devtools will get a suboptimal and possibly buggy interface.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This isn't risky because:
• this introduces a new flag so it's easy to switch if necessary
• this only changes the URL to load the profiler UI
• String changes made/needed:

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a291cce76ba8
[profiler] Use the active tab view in nightly only r=canaltinova

Comment 5

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Is 97 also affected and would benefit from an uplift of this patch as well or this is a problem only with 98 beta? Thanks

Comment 6

[Julien Wajsberg [:julienw]]

This is happening for a long time, but we just enabled the new panel for release and will start to do some more outreach soon, that's why I believe uplifting to Beta only is good enough.

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a291cce76ba8

Comment 8

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Comment on attachment 9262864 [details]
Bug 1754195 - [profiler] Use the active tab view in nightly only r=canaltinova

Approved for 98 beta 3, thanks.

Comment 9

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

https://hg.mozilla.org/releases/mozilla-beta/rev/f6e618328d40