1754280 - cannot create central-as-beta simulations with manually selected tasks to run any more since bug 1753515 landed

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

When developers want to test their fixes for central-as-beta simulation issues, they use the ./mach try release -v 99.0b1 --tasks release-sim --migration central-to-beta --no-push and select the tasks manually, e.g. with ./mach try fuzzy, see https://wiki.mozilla.org/Sheriffing/How_To/Beta_simulations#TRUNK_AS_EARLY_BETA

Can bug 1753515 be reverted?

Comment 1

[Mike Hommey [:glandium]]

OTOH, that setup is subtly broken, see e.g. bug 1746641

Comment 2

[Andrew Halberstadt [:ahal]]

The fact that the logic to modify a local checkout is baked into mach try doesn't sit well with me. I'd prefer if the logic to generate the diff lived elsewhere (in mozrelease perhaps), and then we could write a dedicated mach release-simulation command to apply the diff locally when needed (which mach try could also call into).

I don't feel comfortable about a test function blowing away a user's changes in the working directory, nor do I think it's acceptable for a test to leave the working directory modified. So if we revert there's no way to test these selectors (which isn't ideal given these tests would have caught release bustage that landed on m-c last week).

In the end, if this is blocking a critical workflow, then that is more important than the tests and let's back out. If it's more of a mild inconvenience then I'd prefer we push to move the diff generation logic outside of mach try.

Comment 3

[Andrew Halberstadt [:ahal]]

Alternatively, if --no-push is specified we could print the diff to stdout (or stderr if that's empty of output) instead of modifying the files in-place. This could be a good compromise here (though the whole files_to_change thing still feels out of place in mach try).

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Mike Hommey [:glandium] from comment #1)

OTOH, that setup is subtly broken, see e.g. bug 1746641

The command to use got updated in the documentation.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Andrew Halberstadt [:ahal] from comment #3)

if --no-push is specified we could print the diff to stdout

Developers would still have to apply it. Could a switch --select-tasks be added to apply the changes, call ./mach fuzzy, push to try, and drop the changes?

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1754280 - add try parameter `--stage-changes` for modification of files from try command without submission. r=ahal

Since bug 1753515 the --no-push parameter of the ./mach try release
command doesn't stage the file changes anymore.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c52884b73e61
add try parameter `--stage-changes` for modification of files from try command without submission. r=ahal

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c52884b73e61