1768859 - `mach try fuzzy --save name` errors out

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, defect, P1)

Description

[Paul Adenot (:padenot)]

trees/mozilla-unified::e4fa491e8$ mach try fuzzy --save media
Error running mach:

    ['try', 'fuzzy', '--save', 'media']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file try| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: run() got an unexpected keyword argument 'push'

  File "/home/padenot/src/trees/mozilla-unified/tools/tryselect/mach_commands.py", line 336, in try_fuzzy
    kwargs["query"] = run(command_context, save_query=True, **kwargs_copy)
  File "/home/padenot/src/trees/mozilla-unified/tools/tryselect/mach_commands.py", line 201, in run
    return mod.run(**kwargs)

Sentry event ID: 08c49f25430f4b58af3d97b68527145f
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-C to quit

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahal, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Bug 1768859 - Rename 'push' parameter to 'dry_run' following the changes from c52884b73e612a7202a951f15f3775f6c705e5a4. r=aryx

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1754280

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41caf9dc2d31
Rename 'push' parameter to 'dry_run' following the changes from c52884b73e612a7202a951f15f3775f6c705e5a4. r=aryx DONTBUILD

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/41caf9dc2d31

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:marco, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Marco Castelluccio [:marco]]

No need, most people use try from m-c.