1754376 - Broken click handler in conent tabs and WebExtension Windows

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[John Bieling (:TbSync)]

STR:

Create a simple html page with an <h1 id="test">some header</h1> and a link to "#test" somewhere at the bottom after a lot of text to jump back to the top. Load that page with browser.tabs.create({url}) or browser.windows.create({type: "popup", url}). The link does not work in Thunderbird. It does in Firefox.

This is not only limited to WebExtension windows, but also affects standard content tabs.

There is a standard click handler invoked, which calls ContentDispatchChooser.jsm and tries to access gBrowser.getTabDialogBox which we do not have.

https://searchfox.org/mozilla-central/rev/b697834e78a3ef7613e2fa57c07624b1d9d1c909/toolkit/mozapps/handling/ContentDispatchChooser.jsm#540

But I guess this itself is wrong already. I have not found where that is hooked up to our tabs/windows.

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1754376 - Workaround for broken click handler in content tabs/windows. r=mkmelin

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1754376 - Expose file: and moz-extension: protocol URLs. r=john.bieling

The Gecko link-handling code thinks that Thunderbird doesn't handle these protocols, so if you click on a link it tries to open that link outside of Thunderbird.

The test in this patch wouldn't actually catch this problem (it's uses only HTTP) but might catch related problems in the future, so I'm upgrading it while I remember.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e47825b0f3c9
Expose file: javascript: and moz-extension: protocol URLs. r=john.bieling