1754499 - Load PDF web content in a tab using pdf.js

Status: RESOLVED FIXED

(GeckoView :: PDF Viewer, enhancement, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

It would be nice if GeckoView apps could load PDF files in a tab, similarly to what happens on Desktop with pdf.js.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Brendan, I remember asking you about this a few years ago :-) just curious if anything came to mind as to why we wouldn't be able to adapt Desktop's code on Mobile to do this (or anything else you might want to add really).

Comment 2

[Brendan Dahl [:bdahl]]

I was just discussing this with Marco earlier. There are a few things that come to mind that would be good to fix:

• current UI is focused on larger devices. we probably want a simplified version for mobile
• pinch to zoom was not working well (maybe that's fixed)
• add a path for saving pdfs on android (this may also be fine now)

Comment 3

[Emily Toop (:fluffyemily)]

Fenix would like this delivered in H1 2022. Proposed for 100 or 101.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Amedyne, is the priority for Fenix still correct? We obviously too late for 101.

Comment 5

[Chris Peterson [:cpeterson]]

Kevin recommends we land this Nightly-only first to get some user testing.

Do we want to use PDF.js in Focus?

Comment 6

[Calixte Denizet (:calixte)]

Attachment: Bug 1754499 - Add pdf.js in GeckoView r=#geckoview-reviewers

Just add the minimal stuff in order to be able to view a pdf in using pdf.js
(whatever the content disposition is).
There are still some things to plug (e.g. find stuff), we must change the UI
and add support for pinch-to-zoom, hence we set the pref pdfjs.disabled to true.

Comment 7

[Calixte Denizet (:calixte)]

I ran a try:
https://treeherder.mozilla.org/jobs?repo=try&revision=6708e6633f822a520fb94aa3e66ca2197ba724de

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1531334c19a6
Add pdf.js in GeckoView r=geckoview-reviewers,pdfjs-reviewers,marco,m_kato

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1531334c19a6