1917589 - pdfjs.init is called with an undefined this._isNewProfile on GeckoView

Status: NEW

(GeckoView :: PDF Viewer, defect, P3)

Description

[Pier Angelo Vendrame]

PdfJs.init is called with this._isNewProfile in GeckoViewStartup.sys.mjs, but if I understand correctly, that member is always undefined.
I believe it was a copy&paste error when Pdf.js was added to GV in Bug 1754499 as, apart from here, _isNewProfile is used only in BrowserGlue.sys.mjs, and it's set by its _migrateUI.
I don't think there are unwanted consequences, but I'm opening a bug in case it can be changed with a correct equivalent for GV.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1754499

:calixte, since you are the author of the regressor, bug 1754499, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Calixte Denizet (:calixte)]

Yep for sure it's a copy & paste error.
I'm even not sure we need to call Pdfjs.init in the GV case.