1754549 - Support textTrack.mode: hidden on Ted.com videos

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P3)

Description

[Ania]

As per the decision here, let's support subtitles display in PiP on Ted.com and treat textTrack.mode: hidden as if it was textTrack.mode: showing.

User stories

1. As a user, I would like to see subtitles in PiP if I turned them on in the origin video at Ted.com and then invoked PiP.

Acceptance Criteria/Testing steps
Story 1

1. Turn on captions in the origin video on ted.com.
2. Subtitles are displayed in the origin tab and in PiP when launched and textTrack.mode: hidden.
3. Turn off captions in the origin video -> textTrack.mode: disabled
4. Subtitles are not displayed in the origin video or in PiP.

Comment 1

[sayuree]

Attachment: Bug 1754549 - add support for a hidden mode.r=kpatenio

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 3

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D145650	Bug 1754549 - add support for a hidden mode.r=kpatenio	sabina.zaripova	kpatenio: Back Jan 3, 2023

:sabina.zaripova, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit auto_nag documentation.

Comment 5

[DJ (:dwalker)]

Attachment: Bug 1754549 - enable displaying hidden textTracks in player for specific sites. r?kpatenio

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:mhowell, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbbb8ee93017
enable displaying hidden textTracks in player for specific sites. r=kpatenio

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bbbb8ee93017